My first ATF test

Julio Merino jmmv at freebsd.org
Sun Mar 2 20:44:37 UTC 2014


On Tue, Feb 25, 2014 at 11:11 AM, Peter Holm <peter at holm.cc> wrote:
> In order to understand how ATF works I wrote a small test so I had
> something to work with:
> http://people.freebsd.org/~pho/kern_descrip_test.diff
> Did I get it right?

Hello Peter,

Looks good to me.

One suggestion: that comment with the explanation for dup2_r234131
would be much better represented either as 1) a more descriptive test
case name or 2) a test case description ("descr" metadata property).
The revision number means nothing to readers.  People running the test
suite won't see the comment at all, but they will see the test case
name all the time and they may see the description depending on the
reporting format.

For example, dup2__ebadf_when_2nd_arg_out_of_range would clearly
explain what this is.  You could later put the revision number in the
"descr" property with a textual explanation if so desired.

Cheers


More information about the freebsd-testing mailing list