bin/164095: bsdinstall(8): using optional mount point field while partitioning results in error

[Nathan Whitehorn]

On 01/15/12 12:42, Garrett Cooper wrote:
> On Jan 15, 2012, at 9:57 AM, Nathan Whitehorn<nwhitehorn at freebsd.org>  wrote:
>
>> On 01/13/12 23:31, Ariane van der Steldt wrote:
>>> On Fri, Jan 13, 2012 at 07:50:14PM -0600, Nathan Whitehorn wrote:
>>>> On 01/13/12 19:16, eadler at FreeBSD.org wrote:
>>>>> Old Synopsis: installer: using optional mount point field while partitioning results in error
>>>>> New Synopsis: bsdinstall(8): using optional mount point field while partitioning results in error
>>>>>
>>>>> Responsible-Changed-From-To: freebsd-bugs->freebsd-sysinstall
>>>>> Responsible-Changed-By: eadler
>>>>> Responsible-Changed-When: Sat Jan 14 01:15:02 UTC 2012
>>>>> Responsible-Changed-Why:
>>>>> assign and fix synopsis
>>>>>
>>>>> http://www.freebsd.org/cgi/query-pr.cgi?pr=164095
>>>>> _______________________________________________
>>>>> freebsd-sysinstall at freebsd.org mailing list
>>>>> http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall
>>>>> To unsubscribe, send any mail to "freebsd-sysinstall-unsubscribe at freebsd.org"
>>>>> Installer partition selection claims I must enter a mountpoint.
>>>>> Filling in the mountpoint tells me I must not enter a mountpoint.
>>>> I can't reproduce this. Can you provide more details?
>>> Hi Nathan,
>>>
>>> You need another OS already installed on the disk already, in my case I
>>> reproduced by installing Windows XP in a 8GB partition on an 80GB disk.
>>> If you don't have another OS installed, the dialogs will not appear.
>>>
>>> Please see attached screenshots:
>>> - 01: the dialog that came up
>>> - 02: what I filled in
>>> - 03: the resulting error dialog
>> You can't provide a mountpoint for nested partitions. Since that dialog has a file type field, it can't conditionally remove the bottom line, which only applies to FAT32 or freebsd-ufs or such partitions. I guess something about this could be added to the existing help line, but it's already a little long. At some point we're likely to do a rototill of the partition adding dialog, and will make this a little clearer. For now, you have the error dialog that says you should leave it blank.
>      pc-sysinstall suffers from the same issue [with ZFS at least].
>      sade and sysinstall are the only tools I know of that did the right thing.
> Cheers,
> -Garrett

One solution that has been discussed is to add a partition type menu as 
a second previous screen, which also has the nice effect of giving a 
list of options (with an "Other" entry at the bottom). The only downside 
there is an extra keypress. I don't have time to look into this, but 
patches are very welcome.
-Nathan