bin/119077: [patch] sysinstall(8) - reading packages from index
is extremely slow
Garrett Cooper
yanegomi at gmail.com
Tue Jul 13 15:00:17 UTC 2010
The following reply was made to PR bin/119077; it has been noted by GNATS.
From: Garrett Cooper <yanegomi at gmail.com>
To: bug-followup at FreeBSD.org, michal.botka at seznam.cz
Cc:
Subject: Re: bin/119077: [patch] sysinstall(8) - reading packages from index
is extremely slow
Date: Tue, 13 Jul 2010 07:52:47 -0700
I don't think that this algorithm is correct, because instead of
bisecting the set (like quicksort typically does), it's taking the
first element, and then doing a bubble-like sort.
Regardless of the correctness of the algorithm, if one is concerned
about using quicksort, the replacement algorithm should be using qsort
in libc (because it's more tested and most likely more correct).
Thanks,
-Garrett
More information about the freebsd-sysinstall
mailing list