tws bug ? (LSI SAS 9750)

[John-Mark Gurney]

Jim Harris wrote this message on Fri, Oct 26, 2012 at 13:24 -0700:
> On Fri, Oct 26, 2012 at 1:18 PM, John-Mark Gurney <jmg at funkthat.com> wrote:
> >
> > I'm seeing similar stuff on the hpt27xx driver:
> > (probe18:hpt27xx0:0:18:0): INQUIRY. CDB: 12 0 0 0 24 0
> > (probe18:hpt27xx0:0:18:0): CAM status: Invalid Target ID
> > (probe18:hpt27xx0:0:18:0): Error 22, Unretryable error
> >
> > Should I make a similar change in sys/dev/hpt27xx/osm_bsd.c?  Looks like
> > there are two CAM_TID_INVALID lines, but from reading the comments, only
> > the second one should change...
> >
> > Correct?  If so, I'll try making the change and make sure everything
> > works well.
> >
> 
> Yes - I agree that a similar change is needed, and only to the second
> one in that file.

Ok, I've tested a patch, and so far things look much better...  It shuts
up all the bad probe messges...

Though I ran across a bug where the card went out to lunch giving these
messages:
(da2:hpt27xx0:0:2:0): READ(10). CDB: 28 0 a5 4c ae d8 0 0 58 0 
(da2:hpt27xx0:0:2:0): CAM status: SCSI Status Error
(da2:hpt27xx0:0:2:0): SCSI status: OK
(da3:hpt27xx0:0:3:0): READ(10). CDB: 28 0 a5 4c b9 f0 0 0 50 0 
(da3:hpt27xx0:0:3:0): CAM status: SCSI Status Error
(da3:hpt27xx0:0:3:0): SCSI status: OK

Scott Long suggested the first part of the patch so that an error is
actually generated...  Though it would be good for the sense data to
be set, but not sure where to get it...

Index: osm_bsd.c
===================================================================
--- osm_bsd.c	(revision 241041)
+++ osm_bsd.c	(working copy)
@@ -453,7 +453,7 @@
 		ccb->ccb_h.status = CAM_BUSY;
 		break;
 	default:
-		ccb->ccb_h.status = CAM_SCSI_STATUS_ERROR;
+		ccb->ccb_h.status = CAM_AUTOSENSE_FAIL;
 		break;
 	}
 
@@ -569,7 +569,7 @@
 	vd = ldm_find_target(vbus, ccb->ccb_h.target_id);
 
 	if (!vd) {
-		ccb->ccb_h.status = CAM_TID_INVALID;
+		ccb->ccb_h.status = CAM_SEL_TIMEOUT;
 		xpt_done(ccb);
 		return;
 	}

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."