UFS_DIRHASH panics on a dozen server within 30 hours

Andreas Longwitz longwitz at incore.de
Tue Sep 13 09:46:14 UTC 2011


> You're doing a 25k allocation (why not just go with an even 32k?) but
> you're not enforcing anywhere that if au_length > your #defined value,
> the malloc size is made larger.
> I know it's a nitpick, but if it were me doing a change, I'd use
> MAX(au_length, MAX_AMR_IOCTL) when doing the malloc.

Thank you for this hint, I have posted this to kern/155658.

Dr. Andreas Longwitz

Data Service GmbH
Beethovenstr. 2A
23617 Stockelsdorf
Amtsgericht Lübeck, HRB 318 BS
Geschäftsführer: Wilfried Paepcke, Dr. Andreas Longwitz, Josef Flatau

More information about the freebsd-stable mailing list