Could MSGBUF_SIZE be made a loader tunable?
John Baldwin
jhb at freebsd.org
Tue Jan 18 16:43:40 UTC 2011
On Sunday, January 16, 2011 12:24:27 pm Sergey Kandaurov wrote:
> On 16 January 2011 06:10, <perryh at pluto.rain.com> wrote:
> > Anyone had a chance to look at this?
> >
> > http://lists.freebsd.org/pipermail/freebsd-stable/2010-December/060793.html
>
> To ease testing on head I have regenerated the patch
> (against r216594):
> http://plukky.net/~pluknet/patches/msgbufsize.diff
The one hunk involving tf_rip and PS_STRINGS in amd64 looks to be unrelated.
Also, in subr_param.c, you can assume that MSGBUF_SIZE is always defined
and always assign it as the initial value rather than having an #ifdef.
Finally, I would adjust the wording in the manpage to not say that this
modifies the MSGBUF_SIZE option, but that this tunable is the same as
adjusting MSGBUF_SIZE. Other than that I think it is fine.
--
John Baldwin
More information about the freebsd-stable
mailing list