geli(4) memory leak

Mikolaj Golub trociny at freebsd.org
Mon Apr 4 06:20:14 UTC 2011


On Mon, 4 Apr 2011 01:51:24 +0200 Victor Balada Diaz wrote:

 VBD> On Sun, Apr 03, 2011 at 08:43:45PM +0300, Mikolaj Golub wrote:
 >> 
 >> On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote:
 >> 
 >>  PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote:
 >>  >> For me your patch look correct. But the same issue is for read :-). Also, to
 >>  >> avoid the leak I think we can just do g_destroy_bio() before "all sectors"
 >>  >> check. See the attached patch (had some testing).
 >> 
 >>  PJD> The patch looks good. Please commit.
 >> 
 >> Commited, thanks.

 VBD> I've been out all the weekend, so i've been unable to answer before. I'm glad
 VBD> it got commited and it's great you discovered and fixed the same problem on the
 VBD> read path.

 VBD> Are there any plans to MFC this?

Approximately after one week.

-- 
Mikolaj Golub


More information about the freebsd-stable mailing list