csup in repomirror mode dumps core @ stable/8

[Jeremy Chadwick]

On Thu, Sep 02, 2010 at 07:56:31AM +0200, John Hay wrote:
> On Thu, Sep 02, 2010 at 03:59:07AM +0400, Dmitry Morozovsky wrote:
> > Dear colleagues,
> > 
> > some 2 days ago my repo mirror (stable/8 at amd64) starts dumping core on copying 
> > repo:
> > 
> > ...
> >  SetAttrs CVSROOT-src/Emptydir
> >  Edit CVSROOT-src/access,v
> > Segmentation fault (core dumped)
> > 
> > deleting files from sup/cvsroot-all/ did not help
> > 
> > unfortunately, quick usual `make -DDEBUG_FLAGS=-g' in /usr/src/usr.bin/csup 
> > does not work, and I did not dig into this deeply yet, so trace are without 
> > parameters:

This won't work.  You need to do: make DEBUG_FLAGS="-g3 -ggdb -O0"

The important part is not using -D.  make.conf variables aren't exported
into the compiler environment (I'm not phrasing this eloquently because
I don't know how to describe it).  The rest of the gcc arguments I
provided are highly recommended (especially -O0, otherwise you probably
won't get access to any variable data).

I can confirm this works, by the way.  Look closely at the cc line (past
the initial -O2 -pipe -march=nocona).

cc -O2 -pipe -march=nocona -I.  -I/usr/src/usr.bin/csup/../../contrib/csup -DHAVE_FFLAGS -DNDEBUG -ggdb -g3 -O0 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wno-pointer-sign -c /usr/src/usr.bin/csup/../../contrib/csup/updater.c

-- 
| Jeremy Chadwick                                   jdc at parodius.com |
| Parodius Networking                       http://www.parodius.com/ |
| UNIX Systems Administrator                  Mountain View, CA, USA |
| Making life hard for others since 1977.              PGP: 4BD6C0CB |