duplicity ftp backup / ncftp no longer working since 8.0-Release

[David Horn]

On Fri, Jan 1, 2010 at 9:28 AM, Manfred Usselmann
<usselmann.m at icg-online.de> wrote:
> On Mon, 14 Dec 2009 17:51:31 -0500
> David Horn <dhorn2000 at gmail.com> wrote:
>
>> On Mon, Dec 14, 2009 at 5:31 PM, Manfred Usselmann
>> <usselmann.m at icg-online.de> wrote:
>> > On Mon, 14 Dec 2009 08:17:16 +0100
>> > Manfred Usselmann <usselmann.m at icg-online.de> wrote:
>> >
>> >> On Mon, 14 Dec 2009 00:23:17 -0500
>> >> David Horn <dhorn2000 at gmail.com> wrote:
>> >>
>> >> > I believe that there is something unusual going on with the checking
>> >> > on select() return in ncftp3.  If you change every instance of
>> >> > select() result checking in ftp/ncftp3 from "==1" to ">=1" the problem
>> >> > seems to go away.
>> >> >
>> >> > result = select(sfd + 1, NULL, SELECT_TYPE_ARG234 &ss, NULL,
>> >> > SELECT_TYPE_ARG5 &tv);
>> >> > -if (result == 1) {
>> >> > +if (result >= 1) {
>> >>
>> >> I will try this.
>> >
>> > Did work for me!
>> >
>> > Thanks,
>> > Manfred
>>
>> OK.   I will try to report it to the upstream (ncftp.com/contact), and
>> failing that we could always patch as part of the ncftp 3.2.3 update
>> into freebsd ports, but glad to hear it worked for you.
>
> The port has been updated to 3.2.3 but without a fix.
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=140934 mentions a fix to
> FreeBSD 8 which sounds like it should have solved our issue. Don't know
> why it didn't.
>
> Regards,
> Manfred
>

3.2.3 of ncftp was released by the vendor in July 2009
(http://www.ncftp.org/), so it would not have yet incorporated the
select() result checking changes.

I reported the issue to ncftp, and they acknowledged the issue.  I can
only assume that it will be addressed in the next vendor release
(3.2.4 ?)  The obrien change was a patch to the freebsd  ncftp port
(3.2.2) for the same issue, but only on one of the select() instances
(not all of them).

http://www.freebsd.org/cgi/cvsweb.cgi/ports/ftp/ncftp3/files/Attic/patch-SConnect.c

The obrien commit was since reverted for 3.2.3 since the vendor
included the one instance of select() result checking in the base
code.

So, long story short, you still need to manually patch the source of
ncftp until either

A)  Vendor updates base code (or)
B)  Someone submits a patch to the freebsd port of ftp/ncftp3 (3.2.3)

If you are really concerned about it, create an official patch (use
diff -u) and attach it to your bug report.  Bug reports with patches
are much more likely to see action.

If you are having issues creating a patch let me know and I will try
to find the time to do this in the next week or so. (ENOTIME)

Good Luck.

---Dave Horn