kernel compile failure

[Jeremy Chadwick]

On Mon, Feb 15, 2010 at 03:43:36AM -0600, Larry Rosenman wrote:
> I'm getting:
> cc -c -O2 -frename-registers -pipe -fno-strict-aliasing  -std=c99 -g -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc  -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-sse3 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fstack-protector -Werror  /usr/src/sys/cam/ata/ata_xpt.c
> /usr/src/sys/cam/ata/ata_xpt.c: In function 'probestart':
> /usr/src/sys/cam/ata/ata_xpt.c:331: error: 'ATA_SF_PUIS_SPINUP' undeclared (first use in this function)
> /usr/src/sys/cam/ata/ata_xpt.c:331: error: (Each undeclared identifier is reported only once
> /usr/src/sys/cam/ata/ata_xpt.c:331: error: for each function it appears in.)
> /usr/src/sys/cam/ata/ata_xpt.c: In function 'probedone':
> /usr/src/sys/cam/ata/ata_xpt.c:789: error: 'ATA_RESP_INCOMPLETE' undeclared (first use in this function)
> *** Error code 1
> 
> Stop in /usr/obj/usr/src/sys/BORG.
> *** Error code 1
> 
> Stop in /usr/src.
> *** Error code 1
> 
> Stop in /usr/src.
> 
> with a RELENG_8 csup'ed yesterday.
> 
> Any ideas?

1) When running csup, always take note of what src-all pieces are
getting touched.  I'm 100% certain your csup would have shown that the
above code had recently been modified (commits done to it).

I tend to review every single source code piece that gets committed that
appears relevant or interests me.  ATA or CAM subsystem, SMP, VM, or
UFS/FFS "stuff" is a big focus of mine, so I watch these like a hawk.

2) When encountering a kernel build error like the above, start
reviewing commits on the web:

http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/cam/ata/ata_xpt.c

You can see there that code was modified ~14 hours ago, and who the
committer was.  It's safe to say this commit is responsible for your
problem, since the error is in regards to PUIS (Power Up In Stand-by):


=====
Revision 1.3.2.20: download - view: text, markup, annotated  - select for diffs
Sun Feb 14 19:50:33 2010 UTC (14 hours ago) by mav
Branches: RELENG_8
Diff to: previous 1.3.2.19: preferred, colored; branchpoint 1.3: preferred, colored
Changes since revision 1.3.2.19: +36 -2 lines

SVN rev 203893 on 2010-02-14 19:50:33Z by mav

MFC r203421:
Add Power Up In Stand-by feature support. Device with PUIS enabled
require explicit command to do initial spin-up. Mark that command
with CAM_HIGH_POWER flag, to allow CAM manage staggered spin-up.
=====


I've CC'd the committer here.

-- 
| Jeremy Chadwick                                   jdc at parodius.com |
| Parodius Networking                       http://www.parodius.com/ |
| UNIX Systems Administrator                  Mountain View, CA, USA |
| Making life hard for others since 1977.              PGP: 4BD6C0CB |