Uh, fxp driver broken in current -STABLE build?!

[Pyun YongHyeon]

On Wed, Dec 01, 2010 at 06:11:11PM -0600, Karl Denninger wrote:
> Works in this kernel, checked out on that day:
> 
> FreeBSD 8.1-STABLE #10: Mon Aug 30 06:44:40 CDT 2010    
> karl at FS.denninger.net:/usr/obj/usr/src/sys/KSD-SMP
> 
> fxp0: <Intel 82558 Pro/100 Ethernet> port 0x1000-0x101f mem
> 0x94000000-0x94000fff,0x94100000-0x941fffff irq 21 at device 0.0 on pci6
> fxp0: Enabling Rx lock-up workaround
> miibus0: <MII bus> on fxp0
> fxp0: Ethernet address: 00:a0:c9:a4:78:c3
> fxp0: [ITHREAD]
> 
> (and has been running for months, and for a very long time before that)
> 
> Tried to update to today's check-out and got hosed.
> 
> The driver now keeps resetting and sending out "down" and "up" messages
> repeatedly, and no traffic flows....
> 
> This is the ident I have on the current build:
> 
> fxp0: <Intel 82558 Pro/100 Ethernet> port 0x1000-0x101f mem
> 0x94000000-0x94000fff,0x94100000-0x941fffff irq 21 at device 0.0 on pci6
> fxp0: Enabling Rx lock-up workaround
> miibus0: <MII bus> on fxp0
> fxp0: Ethernet address: 00:a0:c9:a4:78:c3
> fxp0: [ITHREAD]
> 
> Looks the same.....
> 
> Something was touched though on Nov 30 in the CVS tree.
> 
> It looks like there was a fairly serious commit posted on 10-15, and
> some other smaller ones related to VLANs and flow control (which don't
> apply to this configuration.)
> 
> I can't find anything else related...... anyone know what's up here? 
> 
> Probably need to find this as we're going into the 8.2 RELEASE cycle.....
> 
> DMESG from the failed kernel boot is attached.
> 

Thanks for reporting. Try attached patch. It seems there is a bug
in RX lockup detection logic. Your controller is known to RX
lockup free so the workaround should not be enabled. Otherwise
fxp(4) reinitializes the controller every 15 seconds.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fxp.82557.lockup.diff
Type: text/x-diff
Size: 631 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20101202/0d31c556/fxp.82557.lockup.bin