8.0 rc.d scripts less verbose?

[Doug Barton]

First off, this discussion should actually have been on
freebsd-current@ until 8.0-RELEASE is done, but that's a minor issue.


Cezary Morga wrote:
> Dimitry Andric pisze:
>> Index: etc/rc.subr
>> ===================================================================
>> --- etc/rc.subr    (revision 196888)
>> +++ etc/rc.subr    (working copy)
>> @@ -680,7 +680,7 @@ run_rc_command()
>>  
>>                      # setup the full command to run
>>                      #
>> -            [ -z "${rc_quiet}" ] && echo "Starting ${name}."
>> +            echo "Starting ${name}."
>>              if [ -n "$_chroot" ]; then
>>                  _doit="\
>>  ${_nice:+nice -n $_nice }\
> 
> Wouldn't it be easier to set rc_quiet to zero-length value, like
> rc_quiet=""?

That actually would give off too much information because rc_quiet
suppresses error messages about scripts that don't currently have
_enable set to anything useful. That's arguably a bug, but it's a bug
that we've come to depend on.

The attached patch adds a knob you can set in rc.conf to see "Starting
foo" messages again. If people find this useful I'll be glad to commit
it. I'm also open to suggestions for a better name.


Doug

-- 

    This .signature sanitized for your protection

-------------- next part --------------
--- /usr/src/etc/rc.subr	2009-09-16 14:18:07.000000000 -0700
+++ rc.subr	2009-09-16 16:56:39.000000000 -0700
@@ -708,7 +708,7 @@
 
 					# setup the full command to run
 					#
-			[ -z "${rc_quiet}" ] && echo "Starting ${name}."
+			[ -z "${rc_quiet}" -o -n "${rc_starting}" ] && echo "Starting ${name}."
 			if [ -n "$_chroot" ]; then
 				_doit="\
 ${_nice:+nice -n $_nice }\