malo causes sig 12 error and panic on Freebsd 7.2-PRERELEASE (7-STABLE)

[John]

Paul B. Mahol wrote:
> On 3/28/09, John <lists at reiteration.net> wrote:
>> Weongyo Jeong wrote:
>>
>>> It looks something goes wrong so could you please patch if_malo_pci.c
>>> manually it's a very simple patch and test?  Sorry for inconvenience.
>> Hello,
>>
>> Now I get:
>>
>> sudo kldload /boot/kernel/if_malo.ko
>> kldload: can't load /boot/kernel/if_malo.ko: Exec format error
>>
>> [john at potato ~]$ kldstat
>> Id Refs Address            Size     Name
>>  1    8 0xffffffff80100000 7c26c0   kernel
>>  2    1 0xffffffff80a22000 95a      pflog.ko
>>  3    1 0xffffffff80a23000 2ae44    pf.ko
>>  4    1 0xffffffff80a4e000 189ac    linux.ko
>>  5    1 0xffffffff80a67000 aa7a     fuse.ko
> 
> How you compiled new kernel/module?
> This can mean only one thing: you messed something up or
> you are using wrong sources.
> 

It's because the other module wasn't loaded - I didn't see the console 
as I was logged in remotely.

The console showed this:

KLD if_malo.ko: depends on malofw_fw - not available.

So I went back into where the openbsd firmware was and kldloaded 
malofw.ko which succeeded. Then I tried with the (now modified) 
if_malo.ko and got this from the console:

malo0: <Marvell Libertas 88W8335 802.11g Wireless Adapter> mem 
0xfddd0000-0xfddd
ffff,0xfdde0000-0xfddeffff irq 20 at device 6.0 on pci2
malo0: [FILTER]
malo0: unable to allocate memory for cmd buffer, error 12
malo0: unable to attach HAL
device_attach: malo0 attach returned 5

However, the modifications suggested by Weongyo Jeong have made a 
difference in the right direction because the error no longer causes a 
panic.

Now, kldstat gives:

[john at potato ~]$ kldstat
Id Refs Address            Size     Name
  1   22 0xffffffff80100000 7c26c0   kernel
  2    1 0xffffffff80a22000 95a      pflog.ko
  3    1 0xffffffff80a23000 2ae44    pf.ko
  4    2 0xffffffff80a4e000 189ac    linux.ko
  5    1 0xffffffff80a67000 aa7a     fuse.ko
  6    1 0xffffffff80a72000 359b     linprocfs.ko
  7    2 0xffffffff80a76000 1e1ce    malofw.ko
  8    1 0xffffffff80a95000 63c4     if_malo.ko
  9    1 0xffffffff80a9c000 551b5    radeon.ko
10    1 0xffffffff80af2000 113d0    drm.ko

but I can't see it in ifconfig -a.

I haven't got a source problem - of that I'm quite sure. World was made 
only a few days ago, cvsup runs every night, the sources got are those 
I'd expect from following RELENG_7. There is a file in the source tree 
that has this information but right now I'm at a loss as to what it's 
called.
-- 
John