ZFS isntall requirements

[Claude Buisson]

Willem Jan Withagen wrote:
>
> Dmitry Morozovsky wrote:
>> On Sun, 7 Jun 2009, Willem Jan Withagen wrote:
>>
>> WJW> > KS> On Friday 05 June 2009 06:27:23 am Willem Jan Withagen wrote:
>> WJW> > KS> > Hi,
>> WJW> > KS> >
>> WJW> > KS> > I'm trying to get my world to 7.2-stable(amd64),but run
>> into:
>> WJW> > KS> > install  -o root -g wheel -m 444   kgzldr.o /usr/lib
>> WJW> > KS> > ===> sys/boot/i386/libi386 (install)
>> WJW> > KS> > ===> sys/boot/i386/libfirewire (install)
>> WJW> > KS> > ===> sys/boot/i386/loader (install)
>> WJW> > KS> > make: don't know how to make
>> WJW> > KS> > /usr/obj/mnt4/usr/src7/src/tmp/usr/lib/libzfs.a. Stop
>> WJW> > KS> KS> ISTR that the build was temporarily broken several days
>> ago.
>> WJW> > WJW> > WJW> > Well, according to http://tinderbox.freebsd.org/
>> it does not ;)
>> WJW> WJW> I'm not at all familiar with the intrinsics of the tinderbox
>> setup.
>> WJW> But am I free to assume that it is not tested with
>> 'WITHOUT_ZFS=yes'???
>> WJW> WJW> Because that is required to have the trouble surface.
>>
>> Ah well, you're possibly right.  In the interim, you can safely
>> comment this line out, as there's nothing (except small amount of disk
>> space) you lose when you compile ZFS but do not use it.
>
> I was trying to figure out if it was pilot error, or a bug.
> But now I conclude it is a bug.
>
> Should I log a PR?
>
> --WjW
> _______________________________________________
> freebsd-stable at freebsd.org mailing list
> http://lists.freeb, which is invalisd.org/mailman/listinfo/freebsd-stable
> To unsubscribe, send any mail to "freebsd-stable-unsubscribe at freebsd.org"
>
>

This  bug exists from some time and has already be discussed on this list.
The bug stems from the use of the LIBZFS variable in
sys/boot/i386/loader/Makefile: it is not defined in this Makefile if
LOADER_ZFS_SUPPORT is not defined, so its value is taken from
share/mk/bsd.libnames.mk which is invalid in the WITHOUT_CDDL/WITHOUT_ZFS case.

Kip Macy said he would try to fix it by (last) Wednesday. He made a patch, then
reverted it (see the svn history).

You may use the attached simple patch.

Hope it helps,

Claude Buisson


-------------- next part --------------
--- sys/boot/i386/loader/Makefile.orig	2009-05-24 18:32:41.000000000 +0200
+++ sys/boot/i386/loader/Makefile	2009-06-01 15:18:57.000000000 +0200
@@ -18,7 +18,7 @@
 # Put LOADER_ZFS_SUPPORT=yes in /etc/make.conf for ZFS support
 .if defined(LOADER_ZFS_SUPPORT)
 CFLAGS+=	-DLOADER_ZFS_SUPPORT
-LIBZFS=		${.OBJDIR}/../../zfs/libzfsboot.a
+LIBZFSBOOT=	${.OBJDIR}/../../zfs/libzfsboot.a
 .endif

 # Enable PXE TFTP or NFS support, not both.
@@ -105,8 +105,8 @@
 # XXX crt0.o needs to be first for pxeboot(8) to work
 OBJS=	${BTXCRT}

-DPADD=	${LIBFICL} ${LIBFIREWIRE} ${LIBZFS} ${LIBI386} ${LIBSTAND}
-LDADD=	${LIBFICL} ${LIBFIREWIRE} ${LIBZFS} ${LIBI386} -lstand
+DPADD=	${LIBFICL} ${LIBFIREWIRE} ${LIBZFSBOOT} ${LIBI386} ${LIBSTAND}
+LDADD=	${LIBFICL} ${LIBFIREWIRE} ${LIBZFSBOOT} ${LIBI386} -lstand

 .include <bsd.prog.mk>