buildworld fails with "WITHOUT_CDDL=yes" in src.conf

[Claude Buisson]

Daniel O'Connor wrote:
> On Mon, 1 Jun 2009, Pavel Greenberg wrote:
>> Hello everybody!
>> After today's source update I have a problem when doing make
>> buildworld:
>>
>> cc -O2 -fno-strict-aliasing -pipe -march=pentium4
>> -DLOADER_NFS_SUPPORT - DBOOT_FORTH
>> -I/usr/src/sys/boot/i386/loader/../../ficl -I/usr/src/sys/boot/
>> i386/loader/../../ficl/i386 -DLOADER_GZIP_SUPPORT
>> -DLOADER_GPT_SUPPORT -I/usr/ src/sys/boot/i386/loader/../../common
>> -I. -Wall -I/usr/src/sys/boot/i386/ loader/..
>> -I/usr/src/sys/boot/i386/loader/../btx/lib -ffreestanding -
>> mpreferred-stack-boundary=2  -mno-mmx -mno-3dnow -mno-sse -mno-sse2
>> -mno- sse3  -c
>> /usr/src/sys/boot/i386/loader/../../common/interp_forth.c make: don't
>> know how to make /usr/obj/usr/src/tmp/usr/lib/libzfs.a. Stop ***
>> Error code 2
>>
>> Stop in /usr/src/sys/boot/i386.
>> *** Error code 1
>>
>> Stop in /usr/src/sys/boot.
>> *** Error code 1
>>
>> Stop in /usr/src/sys.
>> *** Error code 1
>>
>> Stop in /usr/src.
>> *** Error code 1
>>
>> Stop in /usr/src.
>> *** Error code 1
>>
>> Stop in /usr/src.
>>
>> In my src.conf I have options
>> WITHOUT_CDDL=           true
>> WITHOUT_ZFS=            true
>> because I don't use ZFS, my desktop haven't enought resources for it
>> and I want not to build it. When I updated my OS some weeks ago with
>> the same src.conf process ended OK.
>
> While the above IS a bug it should be pointed out that unless you
> actually load the ZFS kld it won't use any memory on your system.
>

Same here..

The first bug is the use of a LIBZFS variable in
src/sys/boot/i386/loader/Makefile, as this variable is set in
share/mk/bsd.libnames.mk

I just replaced LIBZFS by LIBZFSBOOT and the buildworld succeeded.

The second bug is the use of LOADER_ZFS_SUPPORT without any
consideration of WITHOUT_CDDL and/or WITHOUT_ZFS (or MK_ZFS)

I won't comment the "it won't use any memory on your system"..

Claude Buisson