backporting dummynet's q_time change ? (svn 184414)
oleg at FreeBSD.org
Fri Jan 23 02:25:54 PST 2009
On Fri, Jan 23, 2009 at 11:21:14AM +0100, Luigi Rizzo wrote:
> On Fri, Jan 23, 2009 at 12:44:20PM +0300, Oleg Bulyzhin wrote:
> > On Fri, Jan 23, 2009 at 10:23:12AM +0100, Luigi Rizzo wrote:
> > > this is also in RELENG_7 but i am not sure whether this workaround
> > > has any drawback e.g., when curr_time passes a 32-bit boundary
> > > there seems to be an incorrect setting of q->numbytes
> > Workaround is fine in average. It may fail for:
> > 1) _very_ idle flow (more than 2^32 ticks) while calculating q->avg
> > 2) any flow once per 2^32 ticks
> > then q_time will be updated and things will be ok again.
> understand - my question is whether there is strong objection
> in applying the real fix (the one in HEAD) rather than this
> In my opinion the MFC is quite safe as I explained.
I see. I have no objection but i think this is policy question so i'm not the
right person to ask.
=== Oleg Bulyzhin -- OBUL-RIPN -- OBUL-RIPE -- oleg at rinet.ru ===
More information about the freebsd-stable