RFC: side effects of fixing loader_conf_files handling
Andrew Thompson
thompsa at FreeBSD.org
Wed Jan 21 12:39:36 PST 2009
On Sun, Jan 18, 2009 at 11:29:58PM +0100, Luigi Rizzo wrote:
> hi,
>
> Previously, the check for new assignments was incorrect, and it happened
> to ignored assignments which did not result in a buffer reallocation
> by the Forth interpreter (essentially, any string not longer
> than the current one was ignored).
>
> An annoying side effect of the fix is that now people who (mistakenly)
> copied /boot/defaults/loader.conf into /boot/loader.conf (and
> possibly edit it), now create a loop because their /boot/loader.conf
> now contains
>
> loader_conf_files="/boot/device.hints /boot/loader.conf /boot/loader.conf.local"
>
> which is not just a pure assignments.
>
> I think we should remove the use of loader_conf_files=...
> from /boot/defaults/loader.conf, partly to prevent this kind
> of bugs, and partly because it is nice to have only "pure assigments"
> in this file.
>
> If there are no objections, i will look at how to do it.
> Probably this requires putting the initial list of files
> somewhere else, probably in /boot/loader.rc after the
>
> include /boot/loader.4th
>
> statement.
>
> Comments ?
That sounds good, thanks for working on this.
Andrew
More information about the freebsd-stable
mailing list