Buildworld Fails RELENG_7

[Erik Trulsson]

On Tue, May 20, 2008 at 09:24:11AM -0500, Dave Uhring wrote:
> Tried again this morning with a fresh cvsup from cvsup4.freebsd.org and the
> build went to completion.
> 
> maxwell# grep -v ^# /etc/make.conf
> CPUTYPE?=k8
> CFLAGS= -O2 -fno-strict-aliasing -pipe -m32
> CXXFLAGS+= -fconserve-space
> MAKE_SHELL?=sh
> COPTFLAGS= -O -pipe
> INSTALL=install -C
> MTREE_FOLLOWS_SYMLINKS= -L
> ENABLE_SUID_SSH=
> NO_SENDMAIL=
> NO_PROFILE=
> DOC_LANG=       en_US.ISO8859-1
> 
> maxwell# printenv
> MACHTYPE=i386
> USER=root
> MAIL=/var/mail/root
> SHLVL=2
> VENDOR=intel
> HOME=/root
> PAGER=more
> GROUP=wheel
> LOGNAME=root
> TERM=xterm
> BLOCKSIZE=K
> WINDOWPATH=9
> PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/root/bin
> REMOTEHOST=
> DISPLAY=:0.0
> XAUTHORITY=/root/.Xauthority
> HOST=maxwell.uhring.com
> SHELL=/bin/csh
> OSTYPE=FreeBSD
> PWD=/root
> FTP_PASSIVE_MODE=YES
> HOSTTYPE=FreeBSD
> EDITOR=vi
> WINDOWID=14680077
> XTERM_VERSION=XTerm(235)
> XTERM_LOCALE=C
> TERMCAP=xterm|xterm-color|X11 terminal emulator:ti@:te@:k1=\EOP:k2=\EOQ:k3=\EOR:k4=\EOS:k5=\E[15~:k6=\E[17~:k7=\E[18~:k8=\E[19~:k9=\E[20~:k;=\E[21~:F1=\E[23~:F2=\E[24~:kH=\EOF:@7=\EOF:kI=\E[2~:kh=\EOH:*6=\EOF:kP=\E[5~:kN=\E[6~:ku=\EOA:kd=\EOB:kr=\EOC:kl=\EOD:Km=\E[M:li#24:co#80:am:kn#12:km:mi:ms:xn:AX:bl=^G:is=\E[!p\E[?3;4l\E[4l\E>:rs=\E[!p\E[?3;4l\E[4l\E>:le=^H:AL=\E[%dL:DL=\E[%dM:DC=\E[%dP:al=\E[L:dc=\E[P:dl=\E[M:UP=\E[%dA:DO=\E[%dB:LE=\E[%dD:RI=\E[%dC:ho=\E[H:cd=\E[J:ce=\E[K:cl=\E[H\E[2J:cm=\E[%i%d;%dH:cs=\E[%i%d;%dr:im=\E[4h:ei=\E[4l:ks=\E[?1h\E=:ke=\E[?1l\E>:kD=\E[3~:sf=\n:sr=\EM:st=\EH:ct=\E[3g:sc=\E7:rc=\E8:eA=\E(B\E)0:as=\E(0:ae=\E(B:ml=\El:mu=\Em:up=\E[A:nd=\E[C:md=\E[1m:me=\E[m:mr=\E[7m:so=\E[7m:se=\E[27m:us=\E[4m:ue=\E[24m:vi=\E[?25l:ve=\E[?25h:ut:Co#8:pa#64:op=\E[39;49m:AB=\E[4%dm:AF=\E[3%dm:kb=\010:
> XTERM_SHELL=/bin/csh
> 
> Note the last line.  Even if /etc/make.conf specifies the build shell, that
> is apparently ignored in the build process.

I do not think the build process cares even slightly which shell is used for
xterm.


> 
> The CPUTYPE in /etc/make.conf is also ignored and make chooses one from thin
> air apparently since the cflags used in the build are shown in the last line
> of the compile:
> 
> cc -O2 -fno-strict-aliasing -pipe -m32 -march=athlon-mp -DTM_GMTOFF=tm_gmtoff -DTM_ZONE=tm_zone -DSTD_INSPIRED -DPCTS -DHAVE_LONG_DOUBLE -DTZDIR=\"/usr/share/zoneinfo\" -Demkdir=mkdir -I/usr/src/usr.sbin/zic/zdump/.. -I/usr/src/usr.sbin/zic/zdump/../../../lib/libc/stdtime   -o zdump zdump.o ialloc.o scheck.o 
> 
> I specified CPUTYPE?=k8 but make chose -march=athlon-mp.

Yes, it is supposed to do that.
It used to be the case that gcc did not have any specific -march or -mcpu
flags or optimizations for the K8 architecture, so the make system chooses
-march=athlon-mp since that is the closest architecture that can be
specified.  (Look in /usr/share/mk/bsd.cpu.mk too see how it chooses -march
flags based on your setting of CPUTYPE.)

I am fairly certain however that gcc 4.x does know about the K8 CPUs these
days, so somebody should probably go through bsd.cpu.mk and update it for
the latest gcc (at least for -CURRENT.)




-- 
<Insert your favourite quote here.>
Erik Trulsson
ertr1013 at student.uu.se