7.0BETA4 desktop system also periodically freezes

J.R. Oldroyd fbsd at opal.com
Thu Jan 10 10:40:30 PST 2008


On Thu, 10 Jan 2008 07:33:03 +0200, Kostik Belousov <kostikbel at gmail.com> wrote:
>
> 
> For the SU-imposed jerkiness, try the patch below. Progress on developing
> the change stalled somehow, and I would like to process with it.
> 
> diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c
> index 248ce22..005f915 100644
> --- a/sys/kern/vfs_mount.c
> +++ b/sys/kern/vfs_mount.c
> @@ -2001,6 +2001,12 @@ __mnt_vnode_next(struct vnode **mvp, struct mount *mp)
>  	mtx_assert(MNT_MTX(mp), MA_OWNED);
>  
>  	KASSERT((*mvp)->v_mount == mp, ("marker vnode mount list mismatch"));
> +	if ((*mvp)->v_yield++ == 500) {
> +		MNT_IUNLOCK(mp);
> +		(*mvp)->v_yield = 0;
> +		uio_yield();
> +		MNT_ILOCK(mp);
> +	}
>  	vp = TAILQ_NEXT(*mvp, v_nmntvnodes);
>  	while (vp != NULL && vp->v_type == VMARKER)
>  		vp = TAILQ_NEXT(vp, v_nmntvnodes);
> diff --git a/sys/sys/vnode.h b/sys/sys/vnode.h
> index 0525a43..1ac289a 100644
> --- a/sys/sys/vnode.h
> +++ b/sys/sys/vnode.h
> @@ -131,6 +131,7 @@ struct vnode {
>  		struct socket	*vu_socket;	/* v unix domain net (VSOCK) */
>  		struct cdev	*vu_cdev; 	/* v device (VCHR, VBLK) */
>  		struct fifoinfo	*vu_fifoinfo;	/* v fifo (VFIFO) */
> +		int		vu_yield;	/*   yield count (VMARKER) */
>  	} v_un;
>  
>  	/*
> @@ -185,6 +186,7 @@ struct vnode {
>  #define	v_socket	v_un.vu_socket
>  #define	v_rdev		v_un.vu_cdev
>  #define	v_fifoinfo	v_un.vu_fifoinfo
> +#define	v_yield		v_un.vu_yield
>  
>  /* XXX: These are temporary to avoid a source sweep at this time */
>  #define v_object	v_bufobj.bo_object
> diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c
> index a221b66..02cf45b 100644
> --- a/sys/ufs/ffs/ffs_softdep.c
> +++ b/sys/ufs/ffs/ffs_softdep.c
> @@ -864,6 +864,7 @@ softdep_process_worklist(mp, full)
>  		 */
>  		if (loopcount++ % 128 == 0) {
>  			FREE_LOCK(&lk);
> +			uio_yield();
>  			bwillwrite();
>  			ACQUIRE_LOCK(&lk);
>  		}


Applied this patch.  No change when deleting 1Gb files - the system
still freezes briefly during the deallocation.

	-jr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-stable/attachments/20080110/b53ada8b/signature.pgp


More information about the freebsd-stable mailing list