HEADS UP: inpcb/inpcbinfo rwlocking: coming to a 7-STABLE branch near you

Mike Tancsa mike at sentex.net
Mon Aug 18 16:22:12 UTC 2008


At 10:24 AM 8/18/2008, John Baldwin wrote:

> >   Edit src/sys/conf/files
> >    Add delta 1.1243.2.32 2008.07.30.20.35.41 kmacy
> >   Edit src/sys/netinet/tcp_subr.c
> >    Add delta 1.300.2.4 2008.07.30.20.35.41 kmacy
> >   Edit src/sys/netinet/tcp_syncache.c
> >    Add delta 1.130.2.9 2008.07.30.20.35.41 kmacy
> >    Add delta 1.130.2.10 2008.07.30.20.51.20 kmacy
> >   Edit src/sys/netinet/tcp_syncache.h
> >    Add delta 1.1.2.1 2008.07.30.20.35.41 kmacy
> >   Edit src/sys/netinet/tcp_usrreq.c
> >    Add delta 1.163.2.4 2008.07.30.20.35.41 kmacy
>
>These are changes by Kip to do TCP offload (181013, 181014).
>
>Given that, I think the likeliest changes to cause this are the TCP offload
>changes.  Note that Kip later MFC'd this change which changed ARP stuff:
>
>However, I would stary by narrowing it down to see if Kip's commits cause the
>change.


As I dont have the skills to unwind Robert's patch, I have done the following

csup with date=2008.08.01.00.00.00

which shows the problem.  I then manually grabbed the prior versions 
of the above files

0[smtp2]% ident src/sys/conf/files
src/sys/conf/files:
      $FreeBSD: src/sys/conf/files,v 1.1243.2.30 2008/07/25 17:46:01 jhb Exp $
0[smtp2]% ident src/sys/netinet/tcp_subr.c
src/sys/netinet/tcp_subr.c:
      $FreeBSD: src/sys/netinet/tcp_subr.c,v 1.300.2.3 2008/07/24 
01:13:22 julian Exp $
0[smtp2]% ident src/sys/netinet/tcp_syncache.c
src/sys/netinet/tcp_syncache.c:
      $FreeBSD: src/sys/netinet/tcp_syncache.c,v 1.130.2.8 2008/07/24 
01:13:22 julian Exp $
0[smtp2]% ident src/sys/netinet/tcp_syncache.h
src/sys/netinet/tcp_syncache.h:
      $FreeBSD: src/sys/netinet/tcp_syncache.h,v 1.1 2007/07/27 
00:57:06 silby Exp $
0[smtp2]% ident src/sys/netinet/tcp_usrreq.c
src/sys/netinet/tcp_usrreq.c:
      $FreeBSD: src/sys/netinet/tcp_usrreq.c,v 1.163.2.3 2008/03/01 
11:50:00 rwatson Exp $
0[smtp2]%

All is OK.  So it looks like the above introduced the bug.

         ---Mike 



More information about the freebsd-stable mailing list