libc_r kqueue fd leak
Ed Maste
emaste at phaedrus.sandvine.ca
Tue May 24 18:30:52 PDT 2005
On Tue, May 24, 2005 at 04:01:31PM -0700, John-Mark Gurney wrote:
> yes, the reason I made _stat return ENXIO is that _read and _write are
> not supported by kqueue, and so _stat provided useless information.
> When I added locking, it would only be reading a value that would
> immediately be able to be changed, making it informational at best..
> You'd better spend your syscall calling kevent and getting a few
> events off the queue than trying to figure out how much work you
> have to do... (In one of my programs, I have code that dynamicly
> increases the number of kevent structs I pull off if I get the max..)
>
> After being pestered by ps, I have created a patch.. after a quick test
> that it compiles and runs, I'll commit it... Though libc_r depending
> upon _stat seems broken to me... Who knows what else doesn't implement
> _stat and can't be closed..
Thanks for committing that.
I agree that it's goofy for libc_r to depend on stat, hence the
libc_r uthread_close patch I posted. Unfortunately that would
require a 4.x libc_r for compat too.
-ed
More information about the freebsd-stable
mailing list