4.9-RC and bge

[John Polstra]

On 01-Oct-2003 Damon Permezel wrote:
> I regressed all the way back to:
> 
>   * $FreeBSD: src/sys/dev/bge/if_bge.c,v 1.3.2.20 2003/02/06 21:36:40 ps 
> Exp $
>   * $FreeBSD: src/sys/dev/bge/if_bgereg.h,v 1.1.2.9 2003/02/06 21:36:40 
> ps Exp $
>   * $FreeBSD: src/sys/dev/mii/brgphy.c,v 1.1.2.6 2002/12/11 21:26:56 ps 
> Exp $
> 
> and the problem went away.
> 
> I moved forward all the way back to the present, but modified the 
> brgphy.c so as
> not to enable Wirespeed ethernet, and that was not an issue.
> 
> I am moving back again so that I can get some work done.
> 
> I am willing to try whatever experiments you want.

Thanks, Damon, this is very helpful.  As Paul Saab said in a
different e-mail, we need to figure out which revision introduced
this problem.  Here are my guesses as to which revision of if_bge.c
was the culprit:

    Revision 1.3.2.22 is the most likely candidate, especially the
    changes having to do with autopolling.  The Linux driver doesn't
    use autopolling at all, and I think it's just a big source of
    trouble for us.

    Revision 1.3.2.23 could be the one, but I think it's less likely.
    This commit did affect some of the link state detection logic, but
    I think the changes are OK.

    Revision 1.3.2.25 is also a possible culprit.

    Revision 1.3.2.24 is huge.  I don't think it's the culprit, but
    its sheer size makes it suspect anyway.

I doubt that any of the other commits had anything to do with this
problem.

If you have time to experiment with backing the driver out to
revisions in the range 1.3.2.21 thru 1.3.2.25, I think it would
isolate the source of the bug for us.

Thanks,
John