SA-12:04 commit on RELENG_8_1 incorrect?

Bjoern A. Zeeb bz at freebsd.org
Sat Jun 16 18:14:14 UTC 2012


On 16. Jun 2012, at 17:57 , Steven Chamberlain wrote:

> Hi,
> 
> This was the commit of SA-12:04.sysret to RELENG_7_4, which makes sense
> to me:
> 
> http://svnweb.freebsd.org/base/releng/7.4/sys/amd64/amd64/trap.c?r1=216618&r2=236953
> 
> But when it was applied to RELENG_8_1, it looks wrong, as if it was
> applied in the wrong place.  The indentation is broken, and the code
> inserted looks like it wouldn't be effective:
> 
> http://svnweb.freebsd.org/base/releng/8.1/sys/amd64/amd64/trap.c?revision=236953&view=markup#l965
> 
> Please could someone take a look at this and let me know if it was
> really intended.

That 8.1 one is definitively wrong and had gone unnoticed.  I'll make
sure it'll be fixed.   Thanks a lot for letting us know.

/bz

-- 
Bjoern A. Zeeb                                 You have to have visions!
   It does not matter how good you are. It matters what good you do!



More information about the freebsd-security mailing list