iSCSI/luns/check-condition

Scott Long scottl at samsco.org
Sun Aug 27 14:07:31 UTC 2006


Danny Braniss wrote:

> i guess what this just proves, yet again, that programs work,
> even if the programmer was _____ (fill in the blanks)
> 
> ...
> 
>>     ccb_h->status |= CAM_AUTOSNS_VALID;			<----------------------
>>
>>and
>>...
>>	  case 0x02: 	// Check Condition
>>	       if(pq != NULL) // XXX: check for data ...
>>		    getSenseData(status, ccb, pq);
>>
>>	  case 0x14:	// Intermediate-Condition Met
>>	  case 0x10:	// Intermediate
>>	  case 0x04:	// Condition Met
>>	       ccb_h->status = CAM_REQ_CMP_ERR; //CAM_SCSI_STATUS_ERROR; <--------------
>>	       break;
>>...
>>
> 
> 
> danny
> 
> 

Good catch.  That is a common mistake when dealing with CAM =-)
Arguably, cam_periph_error() shouldn't be so fragile and prone to
loops.

Scott



More information about the freebsd-scsi mailing list