[patch] Fix for ia64 tinderbox failure

Kenneth D. Merry ken at kdm.org
Wed Apr 30 22:23:20 PDT 2003


On Wed, Apr 30, 2003 at 17:12:35 -0700, Marcel Moolenaar wrote:
> Gang,
> 
> Please review the attached patch to fix the "variable may be used
> uninitialized" warning (and thus build failure) on ia64.

I just checked in a slightly different fix.  I just initialized maxsector
and block_len to 0 at the beginning of dagetcapacity().

I guess the ia64 backend isn't as smart as the i386 backend.

> Index: scsi_da.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/cam/scsi/scsi_da.c,v
> retrieving revision 1.140
> diff -u -r1.140 scsi_da.c
> --- scsi_da.c	30 Apr 2003 13:36:51 -0000	1.140
> +++ scsi_da.c	1 May 2003 00:07:59 -0000
> @@ -1821,7 +1821,7 @@
>  		if (maxsector != 0xffffffff)
>  			goto done;
>  	} else
> -		goto done;
> +		goto fail;
>  
>  	rcaplong = (struct scsi_read_capacity_data_long *)rcap;
>  
> @@ -1858,6 +1858,8 @@
>  
>  	if (error == 0)
>  		dasetgeom(periph, block_len, maxsector);
> +
> +fail:
>  
>  	xpt_release_ccb(ccb);
>  

Ken
-- 
Kenneth Merry
ken at kdm.org


More information about the freebsd-scsi mailing list