conf/166484: [rc] [patch] rc.initdiskless patch for different major versions living together

Jilles Tjoelker jilles at stack.nl
Sun Nov 4 13:40:11 UTC 2012


On Sun, Nov 04, 2012 at 12:30:01PM +0000, Chris Rees wrote:
> The following reply was made to PR conf/166484; it has been noted by GNATS.

> From: Chris Rees <utisoft at gmail.com>
> To: "bug-followup at freebsd.org" <bug-followup at freebsd.org>
> Cc:  
> Subject: Re: conf/166484: [rc] [patch] rc.initdiskless patch for different
>  major versions living together
> Date: Sun, 4 Nov 2012 12:21:22 +0000

>  I think this is a great idea.

>  My only concern is the backslashitis in the finding of $rel, and also
>  the fact that it won't catch 10 properly :)

>  Instead of:

>  rel=`expr \`uname -r\` : '\(.\)'`

>  try:

>  rel=$(expr `uname -r` : '\([0-9][0-9]*\)')

>  Does anyone else have any opinions?

The shell command should be:

rel=$(uname -r)
rel=${rel%%.*}

Is it deliberate that the major release replaces base while the other
items like bcast/${ipba} and ip/${ip} add to it? I think so, with the
assumption that base.${rel} will be a straight copy of the results of
make installworld and make distribution with a DESTDIR, all local
changes living in the source tree or the other directories
rc.initdiskless uses.

-- 
Jilles Tjoelker


More information about the freebsd-rc mailing list