mountd and reload

[Doug Barton]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160

On 03/26/10 12:18, Xin LI wrote:
> On Fri, Mar 26, 2010 at 11:10 AM, John Baldwin <jhb at freebsd.org> wrote:
>> FYI, it would be nice if someone could fix it so that /etc/rc.d/mountd reload
>> works when nfs_server_enable="YES" is set in /etc/rc.conf but
>> mountd_enable="YES" is not explicitly set.
> 
> How would you think about something like this (hackish, though...  I
> think we should perhaps make a 'rcvars' list):

I am opposed to it. We already have a mechanism for starting things that
don't have _enable set.

OTOH I agree that there is a more general problem that our rc.d system
should be smarter about what dependent services need to be enabled for a
given service but that problem should be solved generally. One-off hacks
like this will create a lot of drama and confusion that I would really
prefer to avoid.


Doug


> Index: mountd
> ===================================================================
> --- mountd	(revision 205651)
> +++ mountd	(working copy)
> @@ -10,7 +10,15 @@
>  . /etc/rc.subr
> 
>  name="mountd"
> -rcvar=`set_rcvar`
> +if ! checkyesno mountd_enable 1>/dev/null 2>&1 ; then
> +	if ! checkyesno nfsd_enable 1>/dev/null 2>&1; then
> +		rcvar=nfs_server_enable
> +	else
> +		rcvar=nfsd_enable
> +	fi
> +else
> +	rcvar=`set_rcvar`
> +fi
>  command="/usr/sbin/${name}"
>  pidfile="/var/run/${name}.pid"
>  required_files="/etc/exports"
> 
> Cheers,



- -- 

	... and that's just a little bit of history repeating.
			-- Propellerheads

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)

iEYEAREDAAYFAkuuZ/oACgkQyIakK9Wy8Pt17ACeJUdrNgHDeJmaKw70LGPhPA1D
VVEAn2Fv8i5DX+tO2hvBNnT/0Gn08UFi
=qfVe
-----END PGP SIGNATURE-----