From linimon at FreeBSD.org Wed Sep 2 09:33:25 2009 From: linimon at FreeBSD.org (linimon@FreeBSD.org) Date: Wed Sep 2 09:33:37 2009 Subject: conf/138460: [patch] start local rc scripts in background Message-ID: <200909020933.n829XPkW057303@freefall.freebsd.org> Synopsis: [patch] start local rc scripts in background Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Wed Sep 2 09:32:51 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=138460 From dougb at FreeBSD.org Wed Sep 2 14:36:53 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Wed Sep 2 14:36:59 2009 Subject: conf/138460: [patch] start local rc scripts in background Message-ID: <4A9E82FB.5030202@FreeBSD.org> I object to this patch on at least 2 grounds. First the lack of BEFORE in a script does not mean that it is safe to background it. Some other script could easily depend on the service directly via REQUIRE, or (unfortunately) there could be indirect dependencies that are not properly labeled now because we've never needed to label them. Personally I actively discourage the use of BEFORE because I think it makes it harder to debug ordering problems although it is occasionally necessary. Second it is actually fairly common for locally installed scripts from the ports tree at least to depend on each other, and this is not a bug. The way to approach this would be to add a flag, probably in rc.conf, to indicate that it is safe to background a given service. Then rc.subr would have to grow support for this but that shouldn't be too hard. If you'd like to follow up in that regard you should send a message to freebsd-rc@freebsd.org. Unless someone else really thinks this is a good idea I plan to close this PR. Doug -- This .signature sanitized for your protection From dougb at FreeBSD.org Wed Sep 2 15:10:05 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Wed Sep 2 15:10:11 2009 Subject: conf/138460: [patch] start local rc scripts in background Message-ID: <200909021510.n82FA5iP094906@freefall.freebsd.org> The following reply was made to PR conf/138460; it has been noted by GNATS. From: Doug Barton To: bug-followup@FreeBSD.org, villa.alberto@gmail.com, freebsd-rc@freebsd.org Cc: Subject: Re: conf/138460: [patch] start local rc scripts in background Date: Wed, 02 Sep 2009 07:36:43 -0700 I object to this patch on at least 2 grounds. First the lack of BEFORE in a script does not mean that it is safe to background it. Some other script could easily depend on the service directly via REQUIRE, or (unfortunately) there could be indirect dependencies that are not properly labeled now because we've never needed to label them. Personally I actively discourage the use of BEFORE because I think it makes it harder to debug ordering problems although it is occasionally necessary. Second it is actually fairly common for locally installed scripts from the ports tree at least to depend on each other, and this is not a bug. The way to approach this would be to add a flag, probably in rc.conf, to indicate that it is safe to background a given service. Then rc.subr would have to grow support for this but that shouldn't be too hard. If you'd like to follow up in that regard you should send a message to freebsd-rc@freebsd.org. Unless someone else really thinks this is a good idea I plan to close this PR. Doug -- This .signature sanitized for your protection From ady at freebsd.ady.ro Wed Sep 2 15:19:54 2009 From: ady at freebsd.ady.ro (Adrian Penisoara) Date: Wed Sep 2 15:20:01 2009 Subject: conf/138460: [patch] start local rc scripts in background In-Reply-To: <4A9E82FB.5030202@FreeBSD.org> References: <4A9E82FB.5030202@FreeBSD.org> Message-ID: <78cb3d3f0909020819g7fcbc712j1f9f198936708640@mail.gmail.com> Hi, On Wed, Sep 2, 2009 at 4:36 PM, Doug Barton wrote: > I object to this patch on at least 2 grounds. First the lack of BEFORE > in a script does not mean that it is safe to background it. Some other > script could easily depend on the service directly via REQUIRE, or > (unfortunately) there could be indirect dependencies that are not > properly labeled now because we've never needed to label them. > Personally I actively discourage the use of BEFORE because I think it > makes it harder to debug ordering problems although it is occasionally > necessary. > > Second it is actually fairly common for locally installed scripts from > the ports tree at least to depend on each other, and this is not a bug. > > The way to approach this would be to add a flag, probably in rc.conf, > to indicate that it is safe to background a given service. Then > rc.subr would have to grow support for this but that shouldn't be too > hard. If you'd like to follow up in that regard you should send a > message to freebsd-rc@freebsd.org. > > Unless someone else really thinks this is a good idea I plan to close > this PR. > > I think this idea has some (great ?) merit -- almost all modern OS'es are cutting down on boot times and we should be working on this too. It's true that it would take a lot more work than a simple few-lines patch to do it right, but it's worth working on it, at least personally I intend to work on this at one point [1]. [1] https://blueprints.launchpad.net/enterprisebsd/+spec/ebsd-rc.d-startup-fix Regards, Adrian Penisoara EnterpriseBSD From ady at freebsd.ady.ro Wed Sep 2 15:36:50 2009 From: ady at freebsd.ady.ro (Adrian Penisoara) Date: Wed Sep 2 15:36:56 2009 Subject: conf/138460: [patch] start local rc scripts in background In-Reply-To: <4A9E82FB.5030202@FreeBSD.org> References: <4A9E82FB.5030202@FreeBSD.org> Message-ID: <78cb3d3f0909020836u4ebabe67k67632b4e423ff44e@mail.gmail.com> Hi, Coming back to this... On Wed, Sep 2, 2009 at 4:36 PM, Doug Barton wrote: > I object to this patch on at least 2 grounds. First the lack of BEFORE > in a script does not mean that it is safe to background it. Some other > script could easily depend on the service directly via REQUIRE, or > (unfortunately) there could be indirect dependencies that are not > properly labeled now because we've never needed to label them. > Personally I actively discourage the use of BEFORE because I think it > makes it harder to debug ordering problems although it is occasionally > necessary. > I agree REQUIRE should be used instead of BEFORE. But this still leaves the tricky lexicographical file name ordering in place... > > Second it is actually fairly common for locally installed scripts from > the ports tree at least to depend on each other, and this is not a bug. > > The way to approach this would be to add a flag, probably in rc.conf, > to indicate that it is safe to background a given service. Then > rc.subr would have to grow support for this but that shouldn't be too > hard. If you'd like to follow up in that regard you should send a > message to freebsd-rc@freebsd.org. > How about ditching that flag and just determine from the (keyword) dependency ordering which services may be ran in parallel. Again, the presumption of lexicographical file name ordering may hinder this algorithm -- perhaps enforcing rc.subr keywords instead would solve this. Regards, Adrian Penisoara EnterpriseBSD From ady at freebsd.ady.ro Wed Sep 2 15:50:08 2009 From: ady at freebsd.ady.ro (Adrian Penisoara) Date: Wed Sep 2 15:50:18 2009 Subject: conf/138460: [patch] start local rc scripts in background Message-ID: <200909021550.n82Fo4eU035677@freefall.freebsd.org> The following reply was made to PR conf/138460; it has been noted by GNATS. From: Adrian Penisoara To: Doug Barton Cc: bug-followup@freebsd.org, villa.alberto@gmail.com, freebsd-rc@freebsd.org Subject: Re: conf/138460: [patch] start local rc scripts in background Date: Wed, 2 Sep 2009 17:19:50 +0200 --0015174c35045cf71b047299cca0 Content-Type: text/plain; charset=ISO-8859-1 Hi, On Wed, Sep 2, 2009 at 4:36 PM, Doug Barton wrote: > I object to this patch on at least 2 grounds. First the lack of BEFORE > in a script does not mean that it is safe to background it. Some other > script could easily depend on the service directly via REQUIRE, or > (unfortunately) there could be indirect dependencies that are not > properly labeled now because we've never needed to label them. > Personally I actively discourage the use of BEFORE because I think it > makes it harder to debug ordering problems although it is occasionally > necessary. > > Second it is actually fairly common for locally installed scripts from > the ports tree at least to depend on each other, and this is not a bug. > > The way to approach this would be to add a flag, probably in rc.conf, > to indicate that it is safe to background a given service. Then > rc.subr would have to grow support for this but that shouldn't be too > hard. If you'd like to follow up in that regard you should send a > message to freebsd-rc@freebsd.org. > > Unless someone else really thinks this is a good idea I plan to close > this PR. > > I think this idea has some (great ?) merit -- almost all modern OS'es are cutting down on boot times and we should be working on this too. It's true that it would take a lot more work than a simple few-lines patch to do it right, but it's worth working on it, at least personally I intend to work on this at one point [1]. [1] https://blueprints.launchpad.net/enterprisebsd/+spec/ebsd-rc.d-startup-fix Regards, Adrian Penisoara EnterpriseBSD --0015174c35045cf71b047299cca0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi,

On Wed, Sep 2, 2009 at 4:= 36 PM, Doug Barton <dougb@freebsd.org> wrote:
I object to this patch on at least 2 grounds. First the lack of BEFORE
in a script does not mean that it is safe to background it. Some other
script could easily depend on the service directly via REQUIRE, or
(unfortunately) there could be indirect dependencies that are not
properly labeled now because we've never needed to label them.
Personally I actively discourage the use of BEFORE because I think it
makes it harder to debug ordering problems although it is occasionally
necessary.

Second it is actually fairly common for locally installed scripts from
the ports tree at least to depend on each other, and this is not a bug.

The way to approach this would be to add a flag, probably in rc.conf,
to indicate that it is safe to background a given service. Then
rc.subr would have to grow support for this but that shouldn't be too hard. If you'd like to follow up in that regard you should send a
message to freebsd-rc@freebsd.org= .

Unless someone else really thinks this is a good idea I plan to close
this PR.


=A0=A0I think this idea has some (grea= t ?) merit -- almost all modern OS'es are cutting down on boot times an= d we should be working on this too.
=A0=A0It's true that it w= ould take a lot more work than a simple few-lines patch to do it right, but= it's worth working on it, at least personally I intend to work on this= at one point [1].


Regards,=
Adrian Penisoara
EnterpriseBSD
--0015174c35045cf71b047299cca0-- From bugmaster at FreeBSD.org Mon Sep 7 11:07:07 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Sep 7 11:09:29 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200909071107.n87B76n5010361@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/138460 rc [patch] start local rc scripts in background o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 62 problems total. From pjd at FreeBSD.org Wed Sep 9 18:31:25 2009 From: pjd at FreeBSD.org (pjd@FreeBSD.org) Date: Wed Sep 9 18:31:31 2009 Subject: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management Message-ID: <200909091831.n89IVOS9065418@freefall.freebsd.org> Synopsis: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management State-Changed-From-To: open->closed State-Changed-By: pjd State-Changed-When: śro 9 wrz 2009 18:14:21 UTC State-Changed-Why: Thank you for your patch, but I already committed something along those line. rc.d/zfs script was broken and there is now also rc.d/zvol script. It was created so ZVOL-based file systems can be mounted from /etc/fstab. Using ZVOL property to setup swap was intended - ZFS file systems are also not mounted from /etc/fstab. All in all using ZVOL for swap is unreliable anyway. Responsible-Changed-From-To: freebsd-rc->pjd Responsible-Changed-By: pjd Responsible-Changed-When: śro 9 wrz 2009 18:14:21 UTC Responsible-Changed-Why: I'll take this one. http://www.freebsd.org/cgi/query-pr.cgi?pr=120228 From ady at freebsd.ady.ro Fri Sep 11 10:34:49 2009 From: ady at freebsd.ady.ro (Adrian Penisoara) Date: Fri Sep 11 10:34:56 2009 Subject: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management In-Reply-To: <200909091831.n89IVOS9065418@freefall.freebsd.org> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> Message-ID: <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> Hi, On Wed, Sep 9, 2009 at 8:31 PM, wrote: > Synopsis: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management > > State-Changed-From-To: open->closed > State-Changed-By: pjd > State-Changed-When: ?ro 9 wrz 2009 18:14:21 UTC > State-Changed-Why: > Thank you for your patch, but I already committed something along those line. We're probably speaking of SVN changeset 195938 ? > rc.d/zfs script was broken and there is now also rc.d/zvol script. It was > created so ZVOL-based file systems can be mounted from /etc/fstab. > Using ZVOL property to setup swap was intended - ZFS file systems are also not > mounted from /etc/fstab. All in all using ZVOL for swap is unreliable anyway. While I do understand the "unreliable" part I still fail to understand why do we need to complicate matters with ZFS user property signatures to mount ZFS swap volumes instead of the traditional /etc/fstab way -- is there a concrete reason for this (besides said reliability) ? Thanks, Adrian Penisoara EnterpriseBSD From pjd at FreeBSD.org Fri Sep 11 12:20:56 2009 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Fri Sep 11 12:21:03 2009 Subject: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management In-Reply-To: <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> Message-ID: <20090911122050.GC1673@garage.freebsd.pl> On Fri, Sep 11, 2009 at 12:34:27PM +0200, Adrian Penisoara wrote: > Hi, > > On Wed, Sep 9, 2009 at 8:31 PM, wrote: > > Synopsis: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management > > > > State-Changed-From-To: open->closed > > State-Changed-By: pjd > > State-Changed-When: ?ro 9 wrz 2009 18:14:21 UTC > > State-Changed-Why: > > Thank you for your patch, but I already committed something along those line. > > We're probably speaking of SVN changeset 195938 ? Yes. > > rc.d/zfs script was broken and there is now also rc.d/zvol script. It was > > created so ZVOL-based file systems can be mounted from /etc/fstab. > > Using ZVOL property to setup swap was intended - ZFS file systems are also not > > mounted from /etc/fstab. All in all using ZVOL for swap is unreliable anyway. > > While I do understand the "unreliable" part I still fail to understand > why do we need to complicate matters with ZFS user property signatures > to mount ZFS swap volumes instead of the traditional /etc/fstab way -- > is there a concrete reason for this (besides said reliability) ? The idea is to keep things consistent. You can still use /etc/fstab to put swap on ZVOLs, no? You can also set mountpoint property for file system to 'legacy' and then you can mount it from to /etc/fstab too. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090911/a95ef2f3/attachment.pgp From ady at freebsd.ady.ro Fri Sep 11 15:20:06 2009 From: ady at freebsd.ady.ro (Adrian Penisoara) Date: Fri Sep 11 15:20:15 2009 Subject: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management In-Reply-To: <20090911122050.GC1673@garage.freebsd.pl> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> <20090911122050.GC1673@garage.freebsd.pl> Message-ID: <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> Hi, On Fri, Sep 11, 2009 at 2:20 PM, Pawel Jakub Dawidek wrote: [...] >> >> We're probably speaking of SVN changeset 195938 ? > > Yes. > >> > rc.d/zfs script was broken and there is now also rc.d/zvol script. It was >> > created so ZVOL-based file systems can be mounted from /etc/fstab. >> > Using ZVOL property to setup swap was intended - ZFS file systems are also not >> > mounted from /etc/fstab. All in all using ZVOL for swap is unreliable anyway. >> >> While I do understand the "unreliable" part I still fail to understand >> why do we need to complicate matters with ZFS user property signatures >> to mount ZFS swap volumes instead of the traditional /etc/fstab way -- >> is there a concrete reason for this (besides said reliability) ? > > The idea is to keep things consistent. You can still use /etc/fstab to > put swap on ZVOLs, no? You can also set mountpoint property for file Actually using /etc/fstab for zvol swap is not quite working in the current setup since /etc/rc.d/swap1 does not automatically swapoff upon shutdown which makes 'zvol stop' attempt to close the (swap) volume(s) while still in use. I guess 'zfs volfini' should be triggered by a shutdown hook similarly to what geom(4) classes are using. I see Guido committed a swapoff hook in changeset 189624 (similar to what I suggested in my initial PR) but immediately backed it out the next day. Funny thing is that this swapoff hook flip-flopped over time, see changesets 135389, 137255. Is there a reason not to have the swap devices automatically unmounted from /etc/swap1 upon shutdown ? > system to 'legacy' and then you can mount it from to /etc/fstab too. > Perhaps not the best idea: what if I export and then import a zpool from one system to another -- then I will have some swap volumes automatically mounted upon boot, breaking POLA. You can argue that ZFS filesystems will also be automatically mounted too, but this is a consistent behavior across different OSes while the discussed swap volume automount is FreeBSD specific. Sorry to insist, but I still think we should we keep it simple... Unless people are already using/depending on this feature. Regards, Adrian. From pjd at FreeBSD.org Fri Sep 11 15:41:47 2009 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Fri Sep 11 15:41:53 2009 Subject: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management In-Reply-To: <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> <20090911122050.GC1673@garage.freebsd.pl> <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> Message-ID: <20090911154142.GF1673@garage.freebsd.pl> On Fri, Sep 11, 2009 at 05:19:41PM +0200, Adrian Penisoara wrote: > Actually using /etc/fstab for zvol swap is not quite working in the > current setup since /etc/rc.d/swap1 does not automatically swapoff > upon shutdown which makes 'zvol stop' attempt to close the (swap) > volume(s) while still in use. > I guess 'zfs volfini' should be triggered by a shutdown hook > similarly to what geom(4) classes are using. > > I see Guido committed a swapoff hook in changeset 189624 (similar to > what I suggested in my initial PR) but immediately backed it out the > next day. Funny thing is that this swapoff hook flip-flopped over > time, see changesets 135389, 137255. > > Is there a reason not to have the swap devices automatically > unmounted from /etc/swap1 upon shutdown ? The answer is simple: we don't want swapoff to fail. There really no point in removing swap on shutdown (it could still be a good idea to do it when administrator executes /etc/rc.d/swap1 stop). We unmount file systems on shutdown, because we want to keep them consistent. There is no need to keep swap consistent, as the data will be useless after reboot anyway. All in all running swapoff at shutdown time increases reboot time and introduce possibility of failure (I think the kernel can panic if there is no enough memory to move everything out of the swap, but I might be wrong here). There are some tricky cases too. For example: # truncate -s 1g /swap.img # mdconfig -a -f /swap.img # swapon /dev/md0 Now if we don't remove swap we won't be able to unmount file system in non-forcible way. > > system to 'legacy' and then you can mount it from to /etc/fstab too. > > > > Perhaps not the best idea: what if I export and then import a zpool > from one system to another -- then I will have some swap volumes > automatically mounted upon boot, breaking POLA. > > You can argue that ZFS filesystems will also be automatically mounted > too, but this is a consistent behavior across different OSes while the > discussed swap volume automount is FreeBSD specific. > > Sorry to insist, but I still think we should we keep it simple... > Unless people are already using/depending on this feature. Please understand that I don't want to disallow swap configuration from /etc/fstab. I'm just giving an option. I'll think about it a bit more and talk to some people what they think about this and I'll get back to you. Maybe this property is indeed redundant, but I don't want to make any rush decisions. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090911/f6de29e6/attachment.pgp From linimon at FreeBSD.org Sat Sep 12 02:10:38 2009 From: linimon at FreeBSD.org (linimon@FreeBSD.org) Date: Sat Sep 12 02:10:49 2009 Subject: conf/138686: [rc.conf] $named_conf in rc.conf is not used Message-ID: <200909120210.n8C2AcrP079920@freefall.freebsd.org> Old Synopsis: $named_conf in rc.conf is not used New Synopsis: [rc.conf] $named_conf in rc.conf is not used Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Sat Sep 12 02:10:12 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=138686 From bugmaster at FreeBSD.org Mon Sep 14 11:07:07 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Sep 14 11:09:15 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200909141107.n8EB77cV072462@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/138686 rc [rc.conf] $named_conf in rc.conf is not used o conf/138460 rc [patch] start local rc scripts in background o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 62 problems total. From dougb at FreeBSD.org Mon Sep 14 22:13:49 2009 From: dougb at FreeBSD.org (dougb@FreeBSD.org) Date: Mon Sep 14 22:13:54 2009 Subject: conf/138460: [patch] start local rc scripts in background Message-ID: <200909142213.n8EMDms3046874@freefall.freebsd.org> Synopsis: [patch] start local rc scripts in background State-Changed-From-To: open->closed State-Changed-By: dougb State-Changed-When: Mon Sep 14 22:13:08 UTC 2009 State-Changed-Why: No support for this idea has arisen on the list, so close the PR. http://www.freebsd.org/cgi/query-pr.cgi?pr=138460 From dougb at FreeBSD.org Tue Sep 15 11:26:54 2009 From: dougb at FreeBSD.org (dougb@FreeBSD.org) Date: Tue Sep 15 11:27:00 2009 Subject: conf/138686: [rc.conf] $named_conf in rc.conf is not used Message-ID: <200909151126.n8FBQr5d081796@freefall.freebsd.org> Synopsis: [rc.conf] $named_conf in rc.conf is not used State-Changed-From-To: open->analyzed State-Changed-By: dougb State-Changed-When: Tue Sep 15 11:22:03 UTC 2009 State-Changed-Why: named does use /etc/namedb/named.conf for its configuration file by default, so this isn't really an error. I will look again at the possibility of tying the $named_conf variable into the script more tightly after 8.0 release. Responsible-Changed-From-To: freebsd-rc->dougb Responsible-Changed-By: dougb Responsible-Changed-When: Tue Sep 15 11:22:03 UTC 2009 Responsible-Changed-Why: This is my area. http://www.freebsd.org/cgi/query-pr.cgi?pr=138686 From dougb at FreeBSD.org Wed Sep 16 21:28:15 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Wed Sep 16 21:28:27 2009 Subject: svn commit: r197196 - head/etc/rc.d In-Reply-To: <200909141652.n8EGqdd1060471@svn.freebsd.org> References: <200909141652.n8EGqdd1060471@svn.freebsd.org> Message-ID: <4AB15865.9030406@FreeBSD.org> I personally would much prefer that people making changes in rc.d-land be more careful about what they change and thoroughly test their changes than to add more code like this that will both hide breakage and become stale over time. Doug Ed Maste wrote: > Author: emaste > Date: Mon Sep 14 16:52:38 2009 > New Revision: 197196 > URL: http://svn.freebsd.org/changeset/base/197196 > > Log: > Protect cross-script invocation by checking that the target script exists. > This allows pruning of rc.d scripts without getting too many ugly boottime > error messages. > > Inspired by phk's r128714 change to netif. > > Modified: > head/etc/rc.d/ppp > > Modified: head/etc/rc.d/ppp > ============================================================================== > --- head/etc/rc.d/ppp Mon Sep 14 16:16:07 2009 (r197195) > +++ head/etc/rc.d/ppp Mon Sep 14 16:52:38 2009 (r197196) > @@ -95,8 +95,12 @@ ppp_poststart() > { > # Re-Sync ipfilter and pf so they pick up any new network interfaces > # > - /etc/rc.d/ipfilter quietresync > - /etc/rc.d/pf quietresync > + if [ -f /etc/rc.d/ipfilter ]; then > + /etc/rc.d/ipfilter quietresync > + fi > + if [ -f /etc/rc.d/pf ]; then > + /etc/rc.d/pf quietresync > + fi > } > > ppp_stop_profile() { > -- This .signature sanitized for your protection From dougb at FreeBSD.org Wed Sep 16 21:59:50 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Wed Sep 16 22:00:02 2009 Subject: svn commit: r197145 - in head: etc/defaults share/man/man5 In-Reply-To: <200909122222.n8CMMV3d099311@svn.freebsd.org> References: <200909122222.n8CMMV3d099311@svn.freebsd.org> Message-ID: <4AB15FCE.70505@FreeBSD.org> [Please direct follow-ups to freebsd-rc@] Hiroki, I realize that you've posted your patches in the past, and I definitely had it in mind to review them in detail and give you feedback on them. However I got focused on my own projects for the pending release, and then since we were so close to the release I did not think you would be committing these changes until after it was done so I let review of these patches slip down my list of priorities. Therefore I ask you to accept my apologies for this "after the fact" review. Before I forget, you keep putting "mfc after 3 days" in your commit messages. You don't actually plan to MFC these changes to RELENG_8 prior to the 8.0-RELEASE do you? I would not be supportive of this given the sweeping nature of the changes and the (unfortunately) small percentage of our userbase that uses and tests IPv6. I think shaking this code out in HEAD for several weeks at least would be a good thing. That said I very much like the idea of integrating IPv6 support into the overall network code, and I am very supportive of that. I do have some small problems with the direction that you've taken in a few areas, which happen to be neatly summarized in this post. Hiroki Sato wrote: > Author: hrs > Date: Sat Sep 12 22:22:31 2009 > New Revision: 197145 > URL: http://svn.freebsd.org/changeset/base/197145 > > Log: > The following changes are added because of > network_ipv6->rc.d/netif integration: > > - $ipv6_enable is now obsolete. Instead, IPv6 is enabled by > default if the kernel supports it, and $ipv6_network_interfaces > is "none" by default. If you want to use IPv6, define > $ipv6_network_interfaces and $ifconfig_xxx_ipv6. In general I have a problem with the idea of drastically changing the semantics of the current code when I can't see any real value in doing so. I object to this change specifically because on my laptop I really like having the ability to easily disable IPv6 when I am not on my home network. My preferred scenario would be something similar to what we have now, which is that if ipv6_enable is set that it takes the same list of interfaces as ipv4 (defaults to AUTO) and that rtadv is enabled by default for each of those interfaces. My feeling is that this not only significantly reduces POLA it will also more precisely fit the way that the vast majority of our users will actually use IPv6. On a "marketing" note I really think it would be valuable to make it as easy as possible for the average user to get IPv6 working. We have IPv4 down to it more or less "just works," I think IPv6 should be the same way. (On a side note, I'd actually like to see DHCP be the default for IPv4 such that if you have DHCP available on a network you wouldn't have to do any configuration at all to get FreeBSD on line, but that's a whole other topic.) > An interface which is in $network_interfaces and not in > $ipv6_network_interfaces will be marked as "inet6 > -auto_linklocal ifdisabled" (see ifconfig(8)). I think that if a user specifies both lists, and that they differ, that this is a very good way to handle it. > - $ipv6_ifconfig_xxx is renamed to ifconfig_xxx_ipv6 for > consistency with other address families. The old variables > still work but can be removed in the future. Note that > ipv6_ifconfig_xxx="..." should be replaced with > ifconfig_xxx_ipv6="inet6 ...". I see that you are giving a warn'ing when the old format is detected, which is good. > - Receiving ICMPv6 Router Advertisement is not automatically > enabled even if there is no manual configuration of IPv6 in > rc.conf. If you want it, define > ifconfig_xxx_ipv6="inet6 ... accept_rtadv". What is the reason for this change? While I am definitely in favor of making it easier to disable rtadv, I still think it should be the default. > - The rc.d/ip6addrctl now chooses address selection policy based > on $ipv6_prefer, not $ipv6_enable. The default is > ipv6_prefer=NO. Once again, what is the reason for this change? My read of the IPv6-using community is that if they have it available they want to use it as a first choice. I know that is certainly my preference. Once again my apologies for the late review, but hopefully this is useful. Doug -- This .signature sanitized for your protection From ady at freebsd.ady.ro Thu Sep 17 00:25:11 2009 From: ady at freebsd.ady.ro (Adrian Penisoara) Date: Thu Sep 17 00:25:17 2009 Subject: conf/120228: [zfs] [patch] Split ZFS volume startup / ease ZFS swap volumes management In-Reply-To: <20090911154142.GF1673@garage.freebsd.pl> References: <200909091831.n89IVOS9065418@freefall.freebsd.org> <78cb3d3f0909110334g6757f08fh57a0ab97c02b2d9a@mail.gmail.com> <20090911122050.GC1673@garage.freebsd.pl> <78cb3d3f0909110819m35f2d5ceo64de128320091a76@mail.gmail.com> <20090911154142.GF1673@garage.freebsd.pl> Message-ID: <78cb3d3f0909161724i4f4b7b3andcd9fed79ca32278@mail.gmail.com> Hi, On Fri, Sep 11, 2009 at 5:41 PM, Pawel Jakub Dawidek wrote: > On Fri, Sep 11, 2009 at 05:19:41PM +0200, Adrian Penisoara wrote: >> ?Actually using /etc/fstab for zvol swap is not quite working in the >> current setup since /etc/rc.d/swap1 does not automatically swapoff >> upon shutdown which makes 'zvol stop' attempt to close the (swap) >> volume(s) while still in use. >> ? I guess 'zfs volfini' should be triggered by a shutdown hook >> similarly to what geom(4) classes are using. >> >> ?I see Guido committed a swapoff hook in changeset 189624 (similar to >> what I suggested in my initial PR) but immediately backed it out the >> next day. Funny thing is that this swapoff hook flip-flopped over >> time, see changesets 135389, 137255. >> >> ?Is there a reason not to have the swap devices automatically >> unmounted from /etc/swap1 upon shutdown ? > > The answer is simple: we don't want swapoff to fail. > > There really no point in removing swap on shutdown (it could still be a > good idea to do it when administrator executes /etc/rc.d/swap1 stop). > We unmount file systems on shutdown, because we want to keep them > consistent. There is no need to keep swap consistent, as the data will > be useless after reboot anyway. > > All in all running swapoff at shutdown time increases reboot time and > introduce possibility of failure (I think the kernel can panic if there > is no enough memory to move everything out of the swap, but I might be > wrong here). Some (if not most) of the Linux distros do turn off swap at shutdown time and AFAIK they did not encounter issues. One more white ball to do the same. > > There are some tricky cases too. For example: > > ? ? ? ?# truncate -s 1g /swap.img > ? ? ? ?# mdconfig -a -f /swap.img > ? ? ? ?# swapon /dev/md0 > > Now if we don't remove swap we won't be able to unmount file system in > non-forcible way. Hmm, I guess we still need to "mdconfig -d" to have a clean filesystem unmount anyway... > >> > system to 'legacy' and then you can mount it from to /etc/fstab too. >> > >> >> ?Perhaps not the best idea: what if I export and then import a zpool >> from one system to another -- then I will have some swap volumes >> automatically mounted upon boot, breaking POLA. >> >> ?You can argue that ZFS filesystems will also be automatically mounted >> too, but this is a consistent behavior across different OSes while the >> discussed swap volume automount is FreeBSD specific. >> >> ?Sorry to insist, but I still think we should we keep it simple... >> Unless people are already using/depending on this feature. > > Please understand that I don't want to disallow swap configuration from > /etc/fstab. I'm just giving an option. Sure. > > I'll think about it a bit more and talk to some people what they think > about this and I'll get back to you. Maybe this property is indeed > redundant, but I don't want to make any rush decisions. > OK, waiting your feedback. Thanks, Adrian Penisoara EnterpriseBSD From jhay at meraka.org.za Thu Sep 17 04:01:07 2009 From: jhay at meraka.org.za (John Hay) Date: Thu Sep 17 04:01:14 2009 Subject: svn commit: r197145 - in head: etc/defaults share/man/man5 In-Reply-To: <4AB15FCE.70505@FreeBSD.org> References: <200909122222.n8CMMV3d099311@svn.freebsd.org> <4AB15FCE.70505@FreeBSD.org> Message-ID: <20090917040101.GA69461@zibbi.meraka.csir.co.za> On Wed, Sep 16, 2009 at 02:59:42PM -0700, Doug Barton wrote: ... > > Hiroki Sato wrote: > > Author: hrs > > Date: Sat Sep 12 22:22:31 2009 > > New Revision: 197145 > > URL: http://svn.freebsd.org/changeset/base/197145 > > > > Log: > > The following changes are added because of > > network_ipv6->rc.d/netif integration: > > > > - $ipv6_enable is now obsolete. Instead, IPv6 is enabled by > > default if the kernel supports it, and $ipv6_network_interfaces > > is "none" by default. If you want to use IPv6, define > > $ipv6_network_interfaces and $ifconfig_xxx_ipv6. > > In general I have a problem with the idea of drastically changing the > semantics of the current code when I can't see any real value in doing > so. I object to this change specifically because on my laptop I really > like having the ability to easily disable IPv6 when I am not on my > home network. > > My preferred scenario would be something similar to what we have now, > which is that if ipv6_enable is set that it takes the same list of > interfaces as ipv4 (defaults to AUTO) and that rtadv is enabled by > default for each of those interfaces. My feeling is that this not only > significantly reduces POLA it will also more precisely fit the way > that the vast majority of our users will actually use IPv6. Can we then have it default to ipv6_enable="YES" and let people who do not want it, put ipv6_enable="NO" in their rc.conf? Most of the rest of the world has changed that we and we were also there a few years ago. (Yes I know because we run ipv6 at work and I can see how many machines just work without people having to fiddle with it. On the FreeBSD boxes you still have to go and enable it. :-((( ) John -- John Hay -- jhay@meraka.csir.co.za / jhay@FreeBSD.org From dougb at FreeBSD.org Thu Sep 17 08:48:26 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Thu Sep 17 08:48:33 2009 Subject: svn commit: r197145 - in head: etc/defaults share/man/man5 In-Reply-To: <20090917040101.GA69461@zibbi.meraka.csir.co.za> References: <200909122222.n8CMMV3d099311@svn.freebsd.org> <4AB15FCE.70505@FreeBSD.org> <20090917040101.GA69461@zibbi.meraka.csir.co.za> Message-ID: <4AB1F7CF.3080905@FreeBSD.org> John Hay wrote: > On Wed, Sep 16, 2009 at 02:59:42PM -0700, Doug Barton wrote: > ... >> Hiroki Sato wrote: >>> Author: hrs >>> Date: Sat Sep 12 22:22:31 2009 >>> New Revision: 197145 >>> URL: http://svn.freebsd.org/changeset/base/197145 >>> >>> Log: >>> The following changes are added because of >>> network_ipv6->rc.d/netif integration: >>> >>> - $ipv6_enable is now obsolete. Instead, IPv6 is enabled by >>> default if the kernel supports it, and $ipv6_network_interfaces >>> is "none" by default. If you want to use IPv6, define >>> $ipv6_network_interfaces and $ifconfig_xxx_ipv6. >> In general I have a problem with the idea of drastically changing the >> semantics of the current code when I can't see any real value in doing >> so. I object to this change specifically because on my laptop I really >> like having the ability to easily disable IPv6 when I am not on my >> home network. >> >> My preferred scenario would be something similar to what we have now, >> which is that if ipv6_enable is set that it takes the same list of >> interfaces as ipv4 (defaults to AUTO) and that rtadv is enabled by >> default for each of those interfaces. My feeling is that this not only >> significantly reduces POLA it will also more precisely fit the way >> that the vast majority of our users will actually use IPv6. > > Can we then have it default to ipv6_enable="YES" and let people who do > not want it, put ipv6_enable="NO" in their rc.conf? Most of the rest > of the world has changed that we and we were also there a few years > ago. (Yes I know because we run ipv6 at work and I can see how many > machines just work without people having to fiddle with it. On the > FreeBSD boxes you still have to go and enable it. :-((( ) Certainly, I agree that "enabled" should be the default. Sorry if I wasn't clear about that. Doug -- This .signature sanitized for your protection From dougb at FreeBSD.org Thu Sep 17 10:42:42 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Thu Sep 17 10:42:49 2009 Subject: 8.0 rc.d scripts less verbose? In-Reply-To: <20090917183525.O73400@sola.nimnet.asn.au> References: <4AAFED75.4020502@andric.com> <4AB099BB.9040603@therek.net> <4AB17CB9.3040704@FreeBSD.org> <20090917183525.O73400@sola.nimnet.asn.au> Message-ID: <4AB21295.5080103@FreeBSD.org> Please follow up to this post on the freebsd-rc@freebsd.org list, thanks. See below for my comments. Ian Smith wrote: > On Wed, 16 Sep 2009, Doug Barton wrote: >> Cezary Morga wrote: >>> Dimitry Andric pisze: >>>> Index: etc/rc.subr >>>> =================================================================== >>>> --- etc/rc.subr (revision 196888) +++ etc/rc.subr >>>> (working copy) @@ -680,7 +680,7 @@ run_rc_command() >>>> >>>> # setup the full command to run # - [ -z >>>> "${rc_quiet}" ] && echo "Starting ${name}." + echo >>>> "Starting ${name}." if [ -n "$_chroot" ]; then _doit="\ >>>> ${_nice:+nice -n $_nice }\ >>> >>> Wouldn't it be easier to set rc_quiet to zero-length value, >>> like rc_quiet=""? >> >> That actually would give off too much information because >> rc_quiet suppresses error messages about scripts that don't >> currently have _enable set to anything useful. That's arguably a >> bug, but it's a bug that we've come to depend on. >> >> The attached patch adds a knob you can set in rc.conf to see >> "Starting foo" messages again. If people find this useful I'll be >> glad to commit it. I'm also open to suggestions for a better >> name. > >> From your patch: > - [ -z "${rc_quiet}" ] && echo "Starting ${name}." > + [ -z "${rc_quiet}" -o -n "${rc_starting}" ] && echo "Starting ${name}." > > Presumably this variable would go in /etc/defaults/rc.conf .. seems > that all the other rc.conf binary choices are either set "YES" or > "NO" rather than something or empty, so perhaps more consistent > with that might be: > > [ -z "${rc_quiet}" -o "${rc_starting}" = "YES" ] && echo "Starting > ${name}." No, we don't test boolean flags for specific values. I've attached a proper patch to this message. > As for name, not fussed, but maybe rc_startmsgs maybe more > indicative? That sounds fine to me, if anyone else has a better idea follow up on the freebsd-rc list. > Also, I agree with Oliver; YES should probably be the default > (POLA) so folks annoyed by 'too much information' in console.log > can disable it. This late in the release cycle I'm comfortable adding a knob, but I'm not comfortable toggling the default. If there is consensus on the freebsd-rc list to make the default "yes" then I will go with that consensus. Dimitry Andric wrote: > On 2009-09-17 09:17, Oliver Fromme wrote: >> My feeling is that hiding all of the "starting" messages is a >> regression that needs to be fixed. I cannot think of a good >> reason why they should be hidden, but there are certainly good >> reasons to display them. > > The commit that introduced this, r179946, has this log message: > > ==== Move the diagnostic output when the rc.subr(8) glue > automatically starts a > service behind $rc_quiet. Instead, output a warning if the > pre-command routine or the command itself failed. Arguably, it's > more useful to know when > a command failed to start than it is to have an endless list of > "Starting ...." lines[1]. > > [1] - This change actually helped me to discover a bug in > rc.d/{lockd,statd} > (fixed in r179941) that used to fail silently before. ==== > > It is really a matter of taste, I guess. There is something to be > said for eliminating verbosity, in order to make real errors more > visible. > > On the other hand, if one of your startup rc scripts hangs (for > whatever reason), it is nice to have an approximate idea which one > it is. :) I tend to agree that the current default is a little too un-verbose. If there is support for adding this knob I'll follow up with re@ to see about getting it into 8.0-release, although I'm not sure how they'll feel about a change like this so late in the cycle. Doug -- This .signature sanitized for your protection -------------- next part -------------- Index: share/man/man5/rc.conf.5 =================================================================== --- share/man/man5/rc.conf.5 (revision 197259) +++ share/man/man5/rc.conf.5 (working copy) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd September 2, 2009 +.Dd September 17, 2009 .Dt RC.CONF 5 .Os .Sh NAME @@ -95,6 +95,13 @@ Informational messages are displayed when a condition that is not serious enough to warrant a warning or an error occurs. +.It Va rc_startmsgs +.Pq Vt bool +If set to +.Dq Li YES , +show +.Dq Starting foo: +when faststart is used (e.g., at boot time). .It Va early_late_divider .Pq Vt str The name of the script that should be used as the Index: etc/defaults/rc.conf =================================================================== --- etc/defaults/rc.conf (revision 197259) +++ etc/defaults/rc.conf (working copy) @@ -23,6 +23,7 @@ rc_debug="NO" # Set to YES to enable debugging output from rc.d rc_info="NO" # Enables display of informational messages at boot. +rc_startmsgs="NO" # Show "Starting foo:" messages at boot rcshutdown_timeout="30" # Seconds to wait before terminating rc.shutdown early_late_divider="FILESYSTEMS" # Script that separates early/late # stages of the boot process. Make sure you know Index: etc/rc.subr =================================================================== --- etc/rc.subr (revision 197259) +++ etc/rc.subr (working copy) @@ -708,7 +708,13 @@ # setup the full command to run # - [ -z "${rc_quiet}" ] && echo "Starting ${name}." + _show_startmsgs=1 + if [ -n "${rc_quiet}" ]; then + if ! checkyesno rc_startmsgs; then + unset _show_startmsgs + fi + fi + [ -n "$_show_startmsgs" ] && echo "Starting ${name}." if [ -n "$_chroot" ]; then _doit="\ ${_nice:+nice -n $_nice }\ From hrs at FreeBSD.org Sun Sep 20 13:41:12 2009 From: hrs at FreeBSD.org (Hiroki Sato) Date: Sun Sep 20 13:41:19 2009 Subject: svn commit: r197145 - in head: etc/defaults share/man/man5 In-Reply-To: <4AB15FCE.70505@FreeBSD.org> References: <200909122222.n8CMMV3d099311@svn.freebsd.org> <4AB15FCE.70505@FreeBSD.org> Message-ID: <20090920.224018.16368211.hrs@allbsd.org> Skipped content of type multipart/mixed-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090920/f1862882/attachment.pgp From bugmaster at FreeBSD.org Mon Sep 21 11:07:03 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Sep 21 11:09:18 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200909211107.n8LB72fJ030402@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 60 problems total. From jhb at freebsd.org Tue Sep 22 17:46:39 2009 From: jhb at freebsd.org (John Baldwin) Date: Tue Sep 22 17:46:45 2009 Subject: 8.0 rc.d scripts less verbose? In-Reply-To: <4AB21295.5080103@FreeBSD.org> References: <20090917183525.O73400@sola.nimnet.asn.au> <4AB21295.5080103@FreeBSD.org> Message-ID: <200909221343.24541.jhb@freebsd.org> On Thursday 17 September 2009 6:42:29 am Doug Barton wrote: > > Also, I agree with Oliver; YES should probably be the default > > (POLA) so folks annoyed by 'too much information' in console.log > > can disable it. > > This late in the release cycle I'm comfortable adding a knob, but I'm > not comfortable toggling the default. If there is consensus on the > freebsd-rc list to make the default "yes" then I will go with that > consensus. I actually vote for getting this into 8.0 and turning the messages back on to undo the current POLA violation in 8.0. The biggest thing I think is just restoring the functionality as the messages are handy when debugging a startup issue. -- John Baldwin From dougb at FreeBSD.org Tue Sep 22 18:51:55 2009 From: dougb at FreeBSD.org (Doug Barton) Date: Tue Sep 22 18:52:01 2009 Subject: 8.0 rc.d scripts less verbose? In-Reply-To: <200909221343.24541.jhb@freebsd.org> References: <20090917183525.O73400@sola.nimnet.asn.au> <4AB21295.5080103@FreeBSD.org> <200909221343.24541.jhb@freebsd.org> Message-ID: <4AB91CBE.5030303@FreeBSD.org> John Baldwin wrote: > On Thursday 17 September 2009 6:42:29 am Doug Barton wrote: >>> Also, I agree with Oliver; YES should probably be the default >>> (POLA) so folks annoyed by 'too much information' in console.log >>> can disable it. >> This late in the release cycle I'm comfortable adding a knob, but I'm >> not comfortable toggling the default. If there is consensus on the >> freebsd-rc list to make the default "yes" then I will go with that >> consensus. > > I actually vote for getting this into 8.0 and turning the messages back on to > undo the current POLA violation in 8.0. The biggest thing I think is just > restoring the functionality as the messages are handy when debugging a > startup issue. I made the change in HEAD 5 days ago with the default to off, I can easily switch that to on if that is the consensus. I also sent a message to re@ around the same time but haven't heard back from them. Doug -- This .signature sanitized for your protection From jhay at meraka.org.za Sat Sep 26 14:37:40 2009 From: jhay at meraka.org.za (John Hay) Date: Sat Sep 26 14:37:45 2009 Subject: zfs boot and fstab chicken and egg problem Message-ID: <20090926143736.GA21588@zibbi.meraka.csir.co.za> Hi, I have setup a zfs only system using 2 mirrored disks and gpart, using gptzfsboot to boot. That part is working well. The problem comes when you need to add things like the linproc filesystem. If you add that to fstab, the rc scripts will try to mount that before the zfs filesystems and fail because rcorder put mountcritlocal before zfs. Should a system that boot from zfs have it the other way around maybe? I understand that my kind of setup is in the minority, but I guess that more and more people will start to use zfs as their primary filesystem. John -- John Hay -- jhay@meraka.csir.co.za / jhay@FreeBSD.org From jilles at stack.nl Sat Sep 26 21:39:46 2009 From: jilles at stack.nl (Jilles Tjoelker) Date: Sat Sep 26 21:39:53 2009 Subject: zfs boot and fstab chicken and egg problem In-Reply-To: <20090926143736.GA21588@zibbi.meraka.csir.co.za> References: <20090926143736.GA21588@zibbi.meraka.csir.co.za> Message-ID: <20090926213945.GB88702@stack.nl> On Sat, Sep 26, 2009 at 04:37:36PM +0200, John Hay wrote: > I have setup a zfs only system using 2 mirrored disks and gpart, using > gptzfsboot to boot. That part is working well. The problem comes when > you need to add things like the linproc filesystem. If you add that to > fstab, the rc scripts will try to mount that before the zfs filesystems > and fail because rcorder put mountcritlocal before zfs. You can probably work around this using the "late" option in fstab. -- Jilles Tjoelker From jhay at meraka.org.za Sun Sep 27 05:13:17 2009 From: jhay at meraka.org.za (John Hay) Date: Sun Sep 27 05:13:24 2009 Subject: zfs boot and fstab chicken and egg problem In-Reply-To: <20090926213945.GB88702@stack.nl> References: <20090926143736.GA21588@zibbi.meraka.csir.co.za> <20090926213945.GB88702@stack.nl> Message-ID: <20090927051312.GA90311@zibbi.meraka.csir.co.za> On Sat, Sep 26, 2009 at 11:39:45PM +0200, Jilles Tjoelker wrote: > On Sat, Sep 26, 2009 at 04:37:36PM +0200, John Hay wrote: > > I have setup a zfs only system using 2 mirrored disks and gpart, using > > gptzfsboot to boot. That part is working well. The problem comes when > > you need to add things like the linproc filesystem. If you add that to > > fstab, the rc scripts will try to mount that before the zfs filesystems > > and fail because rcorder put mountcritlocal before zfs. > > You can probably work around this using the "late" option in fstab. Ahhh, thanks, once you know what to look for it becomes a lot easier. :-) I only found it mentioned in mount(8). Should it not be mentioned in fstab(5) too? noauto is there. John -- John Hay -- jhay@meraka.csir.co.za / jhay@FreeBSD.org From imp at bsdimp.com Sun Sep 27 05:20:52 2009 From: imp at bsdimp.com (M. Warner Losh) Date: Sun Sep 27 05:20:59 2009 Subject: zfs boot and fstab chicken and egg problem In-Reply-To: <20090927051312.GA90311@zibbi.meraka.csir.co.za> References: <20090926143736.GA21588@zibbi.meraka.csir.co.za> <20090926213945.GB88702@stack.nl> <20090927051312.GA90311@zibbi.meraka.csir.co.za> Message-ID: <20090926.232015.-1182932841.imp@bsdimp.com> In message: <20090927051312.GA90311@zibbi.meraka.csir.co.za> John Hay writes: : On Sat, Sep 26, 2009 at 11:39:45PM +0200, Jilles Tjoelker wrote: : > On Sat, Sep 26, 2009 at 04:37:36PM +0200, John Hay wrote: : > > I have setup a zfs only system using 2 mirrored disks and gpart, using : > > gptzfsboot to boot. That part is working well. The problem comes when : > > you need to add things like the linproc filesystem. If you add that to : > > fstab, the rc scripts will try to mount that before the zfs filesystems : > > and fail because rcorder put mountcritlocal before zfs. : > : > You can probably work around this using the "late" option in fstab. : : Ahhh, thanks, once you know what to look for it becomes a lot easier. :-) : I only found it mentioned in mount(8). Should it not be mentioned in : fstab(5) too? noauto is there. All options you can specify in /etc/fstab should be in fstab(5). The question is "which subset should be mentioned elsewhere," not what subset to document in the logical place... I mean, you wouldn't expect to look at tip(8) to find info about ttys(5) format, would you? Warner From bugmaster at FreeBSD.org Mon Sep 28 11:07:03 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Sep 28 11:09:13 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200909281107.n8SB72Th064141@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/138208 rc [rc] [patch] Making rc.firewall (workstation) IPv6 awa o conf/137629 rc [rc] background_dhclient rc.conf option causing double o conf/137470 rc [PATCH] /etc/rc.d/mdconfig2 : prioritize cli parameter o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc [patch] rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 60 problems total.