From jilles at stack.nl Wed Jul 1 10:40:30 2009 From: jilles at stack.nl (Jilles Tjoelker) Date: Wed Jul 1 10:40:37 2009 Subject: RFC: integrate network_ipv6 to netif and tidy up several rc.d scripts In-Reply-To: <20090628.194342.254155418.hrs@allbsd.org> References: <20090628.194342.254155418.hrs@allbsd.org> Message-ID: <20090630224110.GA33900@stack.nl> On Sun, Jun 28, 2009 at 07:43:42PM +0900, Hiroki Sato wrote: > I would like your review on the attached patch. Changes are the > following: > > 1. Integrate IPv6 interface configuration to rc.d/netif. Also, IPv6 > routing and options are handled rc.d/routing and rc.d/netoptions > now. If no INET6, IPv6 configuration is safely ignored. > > 2. rc.conf variable change. > > ipv6_enable -> (removed) > ipv6_ifconfig_IF -> ifconfig_ipv6_IF > ipv6_ifconfig_IF_aliasN -> ifconfig_IF_aliasN (same as IPv4) > > The old variables still valid, but display a warning. > > 3. rc.d/routed and rc.d/route6d now accept standard rc.d variables > like $routed_enable. The old $router_enable, $ipv6_router_enable > and so on are still valid, but display a warning. > > 4. Clean up rc.d/netoptions to adjust it to the rc.d framework. No > functional change but IPv6 specific options are added. > > 5. Remove rc.d/auto_linklocal and rc.d/network_ipv6. No longer > needed. > > 6. Fix rc.d/defaultroute to suppress an extra blank line. > > 7. rc.conf(5) update. The default value of $ipv6_network_interfaces > is changed from "auto" to "none". > > Basically these changes should be backward compatible except for > $ipv6_enable and $ipv6_network_interfaces. Note that a part of these > changes depend on another patch I posted on -net@ recently (ifconfig > ND6 flags and so on), so simply applying the diff to the current > system does not work. > Any comments (or objections) are welcome. Some comments about the shell scripting, inline. > Index: etc/network.subr > =================================================================== > --- etc/network.subr (revision 195123) > +++ etc/network.subr (working copy) > [...] > + # inet6 specific > + if afexists ipv6; then > + if ipv6if $1; then > + if checkyesno ipv6_gateway_enable ]; then What's this ']'? > [...] > -# _ifconfig_getargs if > +# _ifconfig_getargs if [af] > # Echos the arguments for the supplied interface to stdout. > # returns 1 if empty. In general, ifconfig_getargs should be used > # outside this file. > _ifconfig_getargs() > { > _ifn=$1 > + case $2 in > + "") _af= ;; > + *) _af=_$2 ;; > + esac > + This can be done more simply: _af=${2:+_$2} > if [ -z "$_ifn" ]; then > return 1 > fi > > - get_if_var $_ifn ifconfig_IF "$ifconfig_DEFAULT" > + get_if_var $_ifn ifconfig_IF$_af "$ifconfig_DEFAULT" > } > [...] > +# afexists af > +# Returns 0 if the address family is enabled in the kernel > +# 1 otherwise. > +afexists() > +{ > + _af=$1 > + > + case ${_af} in > + inet|ipv4|ip|ip4) > + if ${SYSCTL_N} net.inet > /dev/null; then > + return 0 > + else > + return 1 > + fi > + ;; > + inet6|ipv6|ip6) > + if ${SYSCTL_N} net.inet6 > /dev/null; then > + return 0 > + else > + return 1 > + fi > + ;; > + esac > +} Here and elsewhere, consider using 'local' (even though it's not POSIX, it is already used and rather useful) or not copying the parameter into a variable at all. Otherwise strange bugs may occur due to variables being corrupted by seemingly innocuous function calls. The redirection should be > /dev/null 2>&1 to avoid an error message if the address family is not enabled. There should be a default case which possibly prints an error message and returns 1. > # ipv6if if > # Returns 0 if the interface should be configured for IPv6 and > # 1 otherwise. > ipv6if() > { > - if ! checkyesno ipv6_enable; then > + _if=$1 > + > + if ! afexists ipv6; then > return 1 > fi > + > + # lo0 is always IPv6-enabled > + case $_if in > + lo[0-9]*) > + return 0 > + ;; > + esac > + > case "${ipv6_network_interfaces}" in > [Aa][Uu][Tt][Oo]) > return 0 > @@ -292,14 +367,61 @@ > return 1 > ;; > esac > - for v6if in ${ipv6_network_interfaces}; do > - if [ "${v6if}" = "${1}" ]; then > + for i in ${ipv6_network_interfaces}; do > + if [ "$i" = "$_if" ]; then Unnecessary change which might cause trouble because i is not local. > return 0 > fi > done > return 1 > } > [...] > + > +# ifalias_ipv4_up if > +# Helper function for ifalias_up(). Handles IPv4. > +# > +ifalias_ipv4_up() > +{ > + _ret=1 > + > alias=0 > while : ; do > ifconfig_args=`get_if_var $1 ifconfig_IF_alias${alias}` > - if [ -n "${ifconfig_args}" ]; then > + case "${ifconfig_args}" in > + inet\ *) > ifconfig $1 ${ifconfig_args} alias > alias=$((${alias} + 1)) > _ret=0 > - else > + ;; > + *) > break > - fi > + ;; > + esac > done > return $_ret > } It looks like this will stop processing the aliases as soon as it finds an inet6 one. ifalias_ipv6_up, ifalias_ipv4_down and ifalias_ipv6_down seem similarly affected. > -#ifalias_down if > +# ifalias_ipv6_up if > +# Helper function for ifalias_up(). Handles IPv6. > +# > +ifalias_ipv6_up() > +{ > + _ret=1 > + > + alias=0 > + while : ; do > + ifconfig_args=`get_if_var $1 ifconfig_IF_alias${alias}` > + case "${ifconfig_args}" in > + inet6\ *) > + ifconfig $1 ${ifconfig_args} alias > + alias=$((${alias} + 1)) > + _ret=0 > + ;; > + *) > + break > + ;; > + esac > + done > + > + # backward compatibility: ipv6_ifconfig_IF_aliasN. > + alias=0 > + while : ; do > + ifconfig_args=`get_if_var $1 ipv6_ifconfig_IF_alias${alias}` > + case "${ifconfig_args}" in > + "") > + break > + ;; > + *) > + ifconfig $1 inet6 ${ifconfig_args} alias > + alias=$((${alias} + 1)) > + warn "\$ipv6_ifconfig_$1_alias${alias} is obsolete." > + " Use ifconfig_$1_alias${alias} instead." > + _ret=0 > + ;; > + esac > + done > + return $_ret > +} The warning message is wrong in the sense that ifconfig_$1_alias${alias} will not work if there are also IPv4 aliases. You could count the number of IPv4 aliases and add that in, but it may be more appropriate to print a single warning message. > [...] > +# ipv6_prefix_hostid_addr_up if > +# add IPv6 prefix + hostid addr to the interface $if > +ipv6_prefix_hostid_addr_up() > +{ > + _if=$1 > + prefix=`get_if_var ${_if} ipv6_prefix_IF` > + > + if [ -n "${prefix}" ]; then > + laddr=`network6_getladdr ${_if}` > + hostid=`expr "${laddr}" : 'fe80::\(.*\)%\(.*\)'` Faster: hostid=${laddr#fe80::} hostid=${hostid%\%*} > + for j in ${prefix}; do > + address=$j\:${hostid} > + ifconfig ${_if} inet6 ${address} prefixlen 64 alias > + > + # if I am a router, add subnet router > + # anycast address (RFC 2373). > + if checkyesno ipv6_gateway_enable; then > + ifconfig ${_if} inet6 $j:: prefixlen 64 \ > + alias anycast > + fi > + done > + fi > +} > [...] > @@ -708,6 +1066,7 @@ > > # Get a list of ALL the interfaces and make lo0 first if it's there. > # > + _tmplist= > case ${network_interfaces} in > [Aa][Uu][Tt][Oo]) > _prefix='' Looks like a possible bugfix. Because _tmplist is overwritten in the * case, it may be more appropriate to put this assignment under the auto case. > @@ -737,26 +1096,49 @@ > > # Separate out dhcp and non-dhcp interfaces > # > - _aprefix= > - _bprefix= > - for _if in ${_tmplist} ; do > - if dhcpif $_if; then > - _dhcplist="${_dhcplist}${_aprefix}${_if}" > - [ -z "$_aprefix" ] && _aprefix=' ' > - elif [ -n "`_ifconfig_getargs $_if`" ]; then > - _nodhcplist="${_nodhcplist}${_bprefix}${_if}" > - [ -z "$_bprefix" ] && _bprefix=' ' > - fi > - done > - > + _list= > + _prefix= > case "$type" in > nodhcp) > - echo $_nodhcplist > + for _if in ${_tmplist} ; do > + if ! dhcpif $_if && \ > + [ -n "`_ifconfig_getargs $_if`" ]; then > + _list="${_list}${_prefix}${_if}" > + [ -z "$_prefix" ] && _prefix=' ' > + fi > + done > + echo $_list The _prefix variable is unnecessary complication. Just _list="${_list} ${_if}" will do. Word splitting in echo $_list will drop the initial space. If word splitting weren't acceptable, echo "${_list# }" would remove it as well; this could simplify the auto case above. > [...] > Index: etc/rc.d/addswap > =================================================================== > --- etc/rc.d/addswap (revision 195133) > +++ etc/rc.d/addswap (working copy) > @@ -7,7 +7,6 @@ > # PROVIDE: addswap > # REQUIRE: FILESYSTEMS > -# BEFORE: sysctl > # KEYWORD: nojail > [...] > Index: etc/rc.d/sysctl > =================================================================== > --- etc/rc.d/sysctl (revision 195133) > +++ etc/rc.d/sysctl (working copy) > @@ -5,7 +5,7 @@ > > # PROVIDE: sysctl > # REQUIRE: root > -# BEFORE: DAEMON > +# BEFORE: FILESYSTEMS > . /etc/rc.subr I think these two changes need separate consideration. > [...] > Index: etc/rc.d/defaultroute > =================================================================== > --- etc/rc.d/defaultroute (revision 195133) > +++ etc/rc.d/defaultroute (working copy) > [...] > delay=`expr $delay - 1` delay=$((delay - 1)) > [...] > Index: etc/rc.d/rtadvd > =================================================================== > --- etc/rc.d/rtadvd (revision 195133) > +++ etc/rc.d/rtadvd (working copy) > @@ -40,10 +40,25 @@ > # get a list of interfaces and enable it on them > # > case ${rtadvd_interfaces} in > - '') > + [Aa][Uu][Tt][Oo]|'') > for i in `ifconfig -l` ; do > case $i in > - lo0|gif[0-9]*|stf[0-9]*|faith[0-9]*|lp[0-9]*|sl[0-9]*|tun[0-9]*) > + lo0|\ > + stf[0-9]*|\ > + faith[0-9]*|\ > + lp[0-9]*|\ > + sl[0-9]*|\ > + pflog[0-9]*|\ > + pfsync[0-9]*|\ > + an[0-9]*|\ > + ath[0-9]*|\ > + ipw[0-9]*|\ > + iwi[0-9]*|\ > + iwn[0-9]*|\ > + ral[0-9]*|\ > + wi[0-9]*|\ > + wl[0-9]*|\ > + wpi[0-9]*) > continue > ;; > *) Hmm, any reason you're removing gif[0-9]* here? > Index: etc/rc.d/routing > =================================================================== > --- etc/rc.d/routing (revision 195133) > +++ etc/rc.d/routing (working copy) > @@ -21,17 +21,75 @@ > > routing_start() > { > - static_start > - options_start > + static_start $* > + options_start $* > } Nitpick: use "$@" to preserve the parameters exactly. $* performs word splitting and filename generation on each parameter. (This does not really matter because rc.subr currently breaks it and the called functions don't care.) -- Jilles Tjoelker From hrs at FreeBSD.org Wed Jul 1 19:35:17 2009 From: hrs at FreeBSD.org (Hiroki Sato) Date: Wed Jul 1 19:35:25 2009 Subject: RFC: integrate network_ipv6 to netif and tidy up several rc.d scripts In-Reply-To: <20090630224110.GA33900@stack.nl> References: <20090628.194342.254155418.hrs@allbsd.org> <20090630224110.GA33900@stack.nl> Message-ID: <20090702.043447.219085264.hrs@allbsd.org> Skipped content of type multipart/mixed-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090701/6823ca29/attachment.pgp From kamikaze at bsdforen.de Fri Jul 3 08:00:11 2009 From: kamikaze at bsdforen.de (Dominic Fandrey) Date: Fri Jul 3 08:00:17 2009 Subject: conf/130414: [patch] rc services started with onestart are not stopped upon shutdown Message-ID: <200907030800.n6380A1i098919@freefall.freebsd.org> The following reply was made to PR conf/130414; it has been noted by GNATS. From: Dominic Fandrey To: bug-followup@FreeBSD.org, kamikaze@bsdforen.de Cc: Subject: Re: conf/130414: [patch] rc services started with onestart are not stopped upon shutdown Date: Fri, 03 Jul 2009 09:28:25 +0200 ping Please commit or close. I've been using this patch for 6 months now. Consider it very well tested. It stops postgres, apache and my vpnc connections upon shutdown. Especially that is useful, because if they are not shutdown properly I'm not allowed to log back in for 30 minutes. From bugmaster at FreeBSD.org Mon Jul 6 11:07:06 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Jul 6 11:09:24 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200907061107.n66B751O010911@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/134918 rc rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/120194 rc [patch] UFS volumes on ZVOLs cannot be fsck'd at boot o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 57 problems total. From hrs at FreeBSD.org Mon Jul 6 22:11:24 2009 From: hrs at FreeBSD.org (Hiroki Sato) Date: Mon Jul 6 22:11:37 2009 Subject: RFC: set_rcvar in rc.subr Message-ID: <20090707.070545.02771440.hrs@allbsd.org> Skipped content of type multipart/mixed-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 195 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090706/99aa7f49/attachment.pgp From linimon at FreeBSD.org Thu Jul 9 18:31:59 2009 From: linimon at FreeBSD.org (linimon@FreeBSD.org) Date: Thu Jul 9 18:32:05 2009 Subject: conf/136624: [rc.d] sysctl variables for ipnat are not applied on boot Message-ID: <200907091831.n69IVwKq093719@freefall.freebsd.org> Old Synopsis: sysctl variables for ipnat are not applied on boot New Synopsis: [rc.d] sysctl variables for ipnat are not applied on boot Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Thu Jul 9 18:31:40 UTC 2009 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=136624 From bugmaster at FreeBSD.org Mon Jul 13 11:07:05 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Jul 13 11:09:31 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200907131107.n6DB74ZR040763@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/120194 rc [patch] UFS volumes on ZVOLs cannot be fsck'd at boot o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 58 problems total. From linimon at FreeBSD.org Sat Jul 18 23:21:49 2009 From: linimon at FreeBSD.org (linimon@FreeBSD.org) Date: Sat Jul 18 23:22:05 2009 Subject: conf/136875: [request] _flags appending Message-ID: <200907182321.n6INLmH8048127@freefall.freebsd.org> Old Synopsis: _flags appending New Synopsis: [request] _flags appending Responsible-Changed-From-To: freebsd-bugs->freebsd-rc Responsible-Changed-By: linimon Responsible-Changed-When: Sat Jul 18 23:21:12 UTC 2009 Responsible-Changed-Why: Fix synopsis and assign. http://www.freebsd.org/cgi/query-pr.cgi?pr=136875 From bugmaster at FreeBSD.org Mon Jul 20 11:07:03 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Jul 20 11:09:29 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200907201107.n6KB72sN002419@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/120194 rc [patch] UFS volumes on ZVOLs cannot be fsck'd at boot o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 59 problems total. From serenity at exscape.org Sun Jul 26 12:00:07 2009 From: serenity at exscape.org (Thomas Backman) Date: Sun Jul 26 12:00:14 2009 Subject: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Message-ID: <200907261200.n6QC07fd014511@freefall.freebsd.org> The following reply was made to PR conf/120194; it has been noted by GNATS. From: Thomas Backman To: bug-followup@FreeBSD.org, freebsd-rc@freebsd.org Cc: Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Date: Sun, 26 Jul 2009 13:49:42 +0200 This bug is still relevant and unfixed as of 8.0-BETA2, although I ran into it by being unable to mount ZVOLs using fstab, since /dev/zvol is populated after mountcritlocal runs. My fix was to move ZFS to before mountcritlocal, since the root is already mounted R/W, but I suppose this fix is even better since it solves the fsck problem as well, which I haven't ran in to yet. It would be nice to see this easy fix implemented! Regards, Thomas From serenity at exscape.org Sun Jul 26 12:07:19 2009 From: serenity at exscape.org (Thomas Backman) Date: Sun Jul 26 12:07:24 2009 Subject: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Message-ID: This bug is still relevant and unfixed as of 8.0-BETA2, although I ran into it by being unable to mount ZVOLs using fstab, since /dev/zvol is populated after mountcritlocal runs. My fix was to move ZFS to before mountcritlocal, since the root is already mounted R/W, but I suppose this fix is even better since it solves the fsck problem as well, which I haven't ran in to yet. It would be nice to see this easy fix implemented! Regards, Thomas From bugmaster at FreeBSD.org Mon Jul 27 11:07:02 2009 From: bugmaster at FreeBSD.org (FreeBSD bugmaster) Date: Mon Jul 27 11:09:32 2009 Subject: Current problem reports assigned to freebsd-rc@FreeBSD.org Message-ID: <200907271107.n6RB71h5019079@freefall.freebsd.org> Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o conf/136875 rc [request] _flags appending o conf/136624 rc [rc.d] sysctl variables for ipnat are not applied on b o conf/134918 rc rc.subr fails to detect perl daemons o conf/134660 rc [patch] rc-script for initializing ng_netflow+ng_ipfw o conf/134333 rc PPP configuration problem in the rc.d scripts in combi o conf/134006 rc [patch] Unload console screensaver kernel modules if s o conf/133987 rc [rc.d] defaultroute broken with DHCP in some cases o conf/133890 rc [patch] sshd(8): add multiple profiles to the rc.d scr o conf/132766 rc wait_for_pids() in /etc/rc.subr is dull. o conf/132483 rc rc.subr(8) [patch] setfib(1) support for rc.subr o conf/132476 rc [rc.d] [patch] add support setfib(1) in rc.d/routing o conf/130414 rc [patch] rc services started with onestart are not stop o conf/128299 rc [patch] /etc/rc.d/geli does not mount partitions using o conf/127917 rc [patch] dumpon rejects on start with physmem>swap even o bin/126562 rc rcorder(8) fails to run unrelated startup scripts when o conf/126392 rc [patch] rc.conf ifconfig_xx keywords cannot be escaped o bin/126324 rc [patch] rc.d/tmp: Prevent mounting /tmp in second tim o conf/124747 rc [patch] savecore can't create dump from encrypted swap o conf/124248 rc [jail] [patch] add support for nice value for rc.d/jai o conf/123734 rc [patch] Chipset VIA CX700 requires extra initializatio o conf/123222 rc [patch] Add rtprio(1)/idprio(1) support to rc.subr(8). o conf/122477 rc [patch] /etc/rc.d/mdconfig and mdconfig2 are ignoring o conf/122170 rc [patch] [request] New feature: notify admin via page o o kern/121566 rc [nfs] [request] [patch] ethernet iface should be broug o conf/120431 rc [patch] devfs.rules are not initialized under certain o conf/120406 rc [devd] [patch] Handle newly attached pcm devices (eg. o conf/120228 rc [zfs] [patch] Split ZFS volume startup / ease ZFS swap o conf/120194 rc [patch] UFS volumes on ZVOLs cannot be fsck'd at boot o conf/119874 rc [patch] "/etc/rc.d/pf reload" fails if there are macro o conf/119076 rc [patch] [rc.d] /etc/rc.d/netif tries to remove alias a o bin/118325 rc [patch] [request] new periodic script to test statuses o conf/118255 rc savecore never finding kernel core dumps (rcorder prob o conf/117935 rc [patch] ppp fails to start at boot because of missing o conf/113915 rc [patch] ndis wireless driver fails to associate when i o conf/109980 rc /etc/rc.d/netif restart doesn't destroy cloned_interfa o conf/109562 rc [rc.d] [patch] [request] Make rc.d/devfs usable from c o conf/108589 rc rtsol(8) fails due to default ipfw rules o conf/106009 rc [ppp] [patch] [request] Fix pppoed startup script to p o conf/105689 rc [ppp] [request] syslogd starts too late at boot o conf/105568 rc [patch] [request] Add more flexibility to rc.conf, to o conf/105145 rc [ppp] [patch] [request] add redial function to rc.d/pp o conf/104549 rc [patch] rc.d/nfsd needs special _find_processes functi o conf/102700 rc [geli] [patch] Add encrypted /tmp support to GELI/GBDE o conf/99721 rc [patch] /etc/rc.initdiskless problem copy dotfile in s o conf/99444 rc [patch] Enhancement: rc.subr could easily support star o conf/96343 rc [patch] rc.d order change to start inet6 before pf o conf/93815 rc [patch] Adds in the ability to save ipfw rules to rc.d o conf/92523 rc [patch] allow rc scripts to kill process after a timeo o conf/89870 rc [patch] [request] make netif verbose rc.conf toggle o conf/89061 rc [patch] IPv6 6to4 auto-configuration enhancement o conf/88913 rc [patch] wrapper support for rc.subr o conf/85819 rc [patch] script allowing multiuser mode in spite of fsc o kern/81006 rc ipnat not working with tunnel interfaces on startup o conf/77663 rc Suggestion: add /etc/rc.d/addnetswap after addcritremo o conf/73677 rc [patch] add support for powernow states to power_profi o conf/58939 rc [patch] dumb little hack for /etc/rc.firewall{,6} o conf/56934 rc [patch] rc.firewall rules for natd expect an interface o conf/45226 rc [patch] Fix for rc.network, ppp-user annoyance o conf/44170 rc [patch] Add ability to run multiple pppoed(8) on start 59 problems total. From pjd at FreeBSD.org Mon Jul 27 14:47:19 2009 From: pjd at FreeBSD.org (pjd@FreeBSD.org) Date: Mon Jul 27 14:47:25 2009 Subject: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Message-ID: <200907271447.n6RElJV7094672@freefall.freebsd.org> Synopsis: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot Responsible-Changed-From-To: freebsd-rc->pjd Responsible-Changed-By: pjd Responsible-Changed-When: pon 27 lip 14:46:39 2009 UTC Responsible-Changed-Why: I'll take this one. http://www.freebsd.org/cgi/query-pr.cgi?pr=120194 From pjd at FreeBSD.org Mon Jul 27 15:17:26 2009 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Mon Jul 27 15:17:33 2009 Subject: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot In-Reply-To: <200907261200.n6QC07fd014511@freefall.freebsd.org> References: <200907261200.n6QC07fd014511@freefall.freebsd.org> Message-ID: <20090727144938.GK3144@garage.freebsd.pl> On Sun, Jul 26, 2009 at 12:00:07PM +0000, Thomas Backman wrote: > The following reply was made to PR conf/120194; it has been noted by GNATS. > > From: Thomas Backman > To: bug-followup@FreeBSD.org, > freebsd-rc@freebsd.org > Cc: > Subject: Re: conf/120194: [patch] UFS volumes on ZVOLs cannot be fsck'd at boot > Date: Sun, 26 Jul 2009 13:49:42 +0200 > > This bug is still relevant and unfixed as of 8.0-BETA2, although I ran > into it by being unable to mount ZVOLs using fstab, since /dev/zvol is > populated after mountcritlocal runs. > My fix was to move ZFS to before mountcritlocal, since the root is > already mounted R/W, but I suppose this fix is even better since it > solves the fsck problem as well, which I haven't ran in to yet. > It would be nice to see this easy fix implemented! The problem with proposed patch is that it moves hostid script to before root is mounted read-write and hostid can create /etc/hostid file. Try this patch instead: http://people.freebsd.org/~pjd/patches/zvol_fsck.patch It splits hostid generation from storing it. Now ZVOLs can be initialized before fsck runs. -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090727/34eac6da/attachment.pgp From pjd at FreeBSD.org Tue Jul 28 13:29:22 2009 From: pjd at FreeBSD.org (Pawel Jakub Dawidek) Date: Tue Jul 28 13:29:28 2009 Subject: Review request. Message-ID: <20090728132938.GG1690@garage.freebsd.pl> Hi. I'm looking for a review of the following: Currently there is a problem with fscking UFS file systems created on top of ZVOLs. The problem is that rc.d/fsck runs before rc.d/zfs. The latter makes ZVOLs to appear in /dev/. In such case rc.d/fsck cannot find devfs entry and aborts. We cannot simply move rc.d/zfs before rc.d/fsck, because we first want kern.hostid to be configured (by rc.d/hostid). If we won't wait (hostid will be 0) we can reuse disks which are in use by different systems (eg. in SAN/NAS environment). We also cannot move rc.d/hostid before rc.d/fsck, because rc.d/hostid on first system start stores generated kern.hostuuid in /etc/hostid file, so it needs root file system to be mounted read-write. My fix is to split rc.d/hostid so that rc.d/hostid (which will now run before rc.d/fsck) only generates hostid and sets up sysctls, but doesn't touch root file system and rc.d/hostid_save (which is run after rc.d/root) and only creates /etc/hostid file. With that in place, I can move ZVOL initialization to dedicated rc.d/zvol script which runs before rc.d/fsck. The patch is here: http://people.freebsd.org/~pjd/patches/zvol_fsck.patch -- Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090728/ccd48fe9/attachment.pgp From brooks at freebsd.org Tue Jul 28 15:35:49 2009 From: brooks at freebsd.org (Brooks Davis) Date: Tue Jul 28 15:36:00 2009 Subject: Review request. In-Reply-To: <20090728132938.GG1690@garage.freebsd.pl> References: <20090728132938.GG1690@garage.freebsd.pl> Message-ID: <20090728153559.GB72994@lor.one-eyed-alien.net> On Tue, Jul 28, 2009 at 03:29:38PM +0200, Pawel Jakub Dawidek wrote: > Hi. > > I'm looking for a review of the following: > > Currently there is a problem with fscking UFS file systems created on > top of ZVOLs. The problem is that rc.d/fsck runs before rc.d/zfs. The > latter makes ZVOLs to appear in /dev/. In such case rc.d/fsck cannot > find devfs entry and aborts. We cannot simply move rc.d/zfs before > rc.d/fsck, because we first want kern.hostid to be configured (by > rc.d/hostid). If we won't wait (hostid will be 0) we can reuse disks > which are in use by different systems (eg. in SAN/NAS environment). > We also cannot move rc.d/hostid before rc.d/fsck, because rc.d/hostid on > first system start stores generated kern.hostuuid in /etc/hostid file, > so it needs root file system to be mounted read-write. > > My fix is to split rc.d/hostid so that rc.d/hostid (which will now run > before rc.d/fsck) only generates hostid and sets up sysctls, but doesn't > touch root file system and rc.d/hostid_save (which is run after > rc.d/root) and only creates /etc/hostid file. > > With that in place, I can move ZVOL initialization to dedicated > rc.d/zvol script which runs before rc.d/fsck. > > The patch is here: > > http://people.freebsd.org/~pjd/patches/zvol_fsck.patch This looks fine to me and seems like a good solution to this problem. -- Brooks -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 187 bytes Desc: not available Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20090728/1631bd74/attachment.pgp