conf/104884: Add support EtherChannel configuration to rc.conf

[Florent Thoumie]

Norikatsu Shigemura wrote:
> On Sat, 28 Oct 2006 16:10:18 GMT
> FreeBSD-gnats-submit at FreeBSD.org wrote:
>> Thank you very much for your problem report.
>> It has the internal identification `conf/104884'.
>> The individual assigned to look at your
>> report is: freebsd-bugs. 
>> You can access the state of your problem report at any time
>> via this link:
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=104884
>>> Category:       conf
>>> Responsible:    freebsd-bugs
>>> Synopsis:       Add support EtherChannel configuration to rc.conf
>>> Arrival-Date:   Sat Oct 28 16:10:18 GMT 2006
> 
> 	I chased HEAD.  Please see following patch.
> 	Anyone, please handle this PR?
> 	And I'll make a patch for 6-stable.

I just noticed two other things.

> +# fec_up ifn
            ^^^

fec_up uses fec_interfaces, not $1, so this is wrong.

> +# Configure Fast EtherChannel for interface $ifn. Returns 0 if FEC
> +# arguments were found and configured; returns 1 otherwise.

fec_up is never called with an argument anyway at the moment. It
wouldn't be hard to do: work on $1 or $fec_interfaces if $1 is empty. I
guess we could use both 'fec_up $ifn' and 'gif_up $ifn' in rc.d/netif.

The newly introduced variables also need to be documented in rc.conf.5.
Could you please provide a patch for this?

I also noticed we don't have gif_down (hence no fec_down).

-- 
Florent Thoumie
flz at FreeBSD.org
FreeBSD Committer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 250 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-rc/attachments/20070205/a5193709/signature.pgp