bin/94767: [patch] rcorder(8) dumps core when does not use a proper RCng script (dansguardian)

Ganbold ganbold at micom.mng.net
Tue Mar 28 02:50:23 UTC 2006


The following reply was made to PR bin/94767; it has been noted by GNATS.

From: Ganbold <ganbold at micom.mng.net>
To: bug-followup at FreeBSD.org
Cc:  
Subject: Re: bin/94767: [patch] rcorder(8) dumps core when does not use a
 proper RCng script (dansguardian)
Date: Tue, 28 Mar 2006 11:49:07 +0900

 In Dragonfly rcorder code, those lines which frees memory are commented 
 out.
 Clearer way will be just to delete those lines.
 In any case I just commented out those lines, since it can be used later 
 on.
 So the patch would be:
 
 --- rcorder.c.orig      Tue Jan 17 16:01:00 2006
 +++ rcorder.c   Mon Mar 27 16:41:49 2006
 @@ -757,8 +757,8 @@
                 r_tmp = r;
                 satisfy_req(r, fnode->filename);
                 r = r->next;
 -               if (was_set == 0)
 -                       free(r_tmp);
 +/*             if (was_set == 0)*/
 +/*                     free(r_tmp);*/
         }
         fnode->req_list = NULL;
 
 @@ -797,10 +797,10 @@
         }
 
         DPRINTF((stderr, "nuking %s\n", fnode->filename));
 -       if (was_set == 0) {
 -               free(fnode->filename);
 -               free(fnode);
 -       }
 +/*     if (was_set == 0) {*/
 +/*             free(fnode->filename);*/
 +/*             free(fnode);*/
 +/*     }*/
  }
 
  void
 
 


More information about the freebsd-rc mailing list