buildworld -DWITHOUT_OPENSSL fails at (lib/libbsnmp/libbsnmp (all)) (was: lib/libarchive (depend))

[Devin Teske]

On Jan 13, 2012, at 7:28 PM, Devin Teske wrote:

> Trying to buildworld in RELENG_9 with -DWITHOUT_OPENSSL and getting failures.
> 
> First failure we encountered required the following patch to get past "lib/libarchive (depend)"...
> 
> 
>> 
>> --- lib/libarchive/config_freebsd.h.orig	2012-01-05 03:44:55.000000000 -0800
>> +++ lib/libarchive/config_freebsd.h	2012-01-13 18:43:46.000000000 -0800
>> @@ -176,9 +176,4 @@
>> #define	ARCHIVE_HASH_SHA256_OPENSSL 1
>> #define	ARCHIVE_HASH_SHA384_OPENSSL 1
>> #define	ARCHIVE_HASH_SHA512_OPENSSL 1
>> -#else
>> -#define	ARCHIVE_HASH_MD5_LIBC 1
>> -#define	ARCHIVE_HASH_SHA1_LIBC 1
>> -#define	ARCHIVE_HASH_SHA256_LIBC 1
>> -#define	ARCHIVE_HASH_SHA512_LIBC 1
>> #endif
>> 
>> The above patch allowed the mkdep to succeed and later-compilation in the same directory succeeded (yay).
> 
> However, you don't get far before the next error.
> 
> Making all in lib/libbsnmp/libbsnmp with -DWITHOUT_OPENSSL...
> 
> cc  -I/usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib -DHAVE_ERR_H -DHAVE_GETADDRINFO -DHAVE_STRLCPY -DHAVE_STDINT_H -DHAVE_INTTYPES_H -DQUADFMT='"llu"' -DQUADXFMT='"llx"' -std=gnu99 -fstack-protector -Wsystem-headers -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -c /usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c
> /usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c:371: error: conflicting types for 'snmp_passwd_to_keys'
> /usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmp.h:273: error: previous declaration of 'snmp_passwd_to_keys' was here
> /usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmpcrypto.c:384: error: conflicting types for 'snmp_get_local_keys'
> /usr/src/lib/libbsnmp/libbsnmp/../../../contrib/bsnmp/lib/snmp.h:274: error: previous declaration of 'snmp_get_local_keys' was here
> 

The solution to this appears to be the following patch:

========= BEGIN PATCH ==========
--- contrib/bsnmp/lib/snmpcrypto.c.orig	2011-09-22 17:51:37.000000000 -0700
+++ contrib/bsnmp/lib/snmpcrypto.c	2012-01-15 09:49:27.000000000 -0800
@@ -366,7 +366,7 @@ snmp_pdu_decrypt(const struct snmp_pdu *
 	return (SNMP_CODE_OK);
 }
 
-int
+enum snmp_code
 snmp_passwd_to_keys(struct snmp_user *user, char *passwd __unused)
 {
 	if (user->auth_proto == SNMP_AUTH_NOAUTH &&
@@ -378,7 +378,7 @@ snmp_passwd_to_keys(struct snmp_user *us
 	return (SNMP_CODE_FAILED);
 }
 
-int
+enum snmp_code
 snmp_get_local_keys(struct snmp_user *user, uint8_t *eid __unused,
     uint32_t elen __unused)
 {

========== END PATCH ==========

I'll file a PR later (still trying to get a successful build first).
-- 
Devin

_____________
The information contained in this message is proprietary and/or confidential. If you are not the intended recipient, please: (i) delete the message and all copies; (ii) do not disclose, distribute or use the message in any manner; and (iii) notify the sender immediately. In addition, please be aware that any message addressed to our domain is subject to archiving and review by persons other than the intended recipient. Thank you.