Can't install octave

[Jan Henrik Sylvester]

On 03/05/2010 16:24, Jan Henrik Sylvester wrote:
> On 01/-10/-28163 20:59, Zbigniew Komarnicki wrote:
>> I try to install octave (kde3, kde4 in erlier post) after fresh install
>> FreeBSD 8.0 and freebsd-update to FreeBSD 8.0 p2 on i386 athlon-xp
>> 1660 MHz,
>> but with no success.
>>
>> I forgot to add that I csup-ed the ports tree today.
>
> If I try to rebuild x11-toolkits/fltk, I get the same error. My last
> build of fltk was done before the last commit to that port. The commit
> was based on this problem report:
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=143638
>
>  From the description of that pr: "Note that fltk also has the problem
> of linking against its older version, so you have to deinstall the old
> version to do a successful build."
>
> I have not tested that as I am in no immediate need to rebuild fltk.

There has been one more commit on that port:

http://www.freebsd.org/cgi/cvsweb.cgi/ports/x11-toolkits/fltk/files/patch-src_filename_list.cxx.diff?r1=1.4;r2=1.5;f=h

That one looks suspicious because (__FreeBSD_version >= 730000) make the 
clauses before obsolete.

Before that commit, the condition was true for 8-STABLE and 9-CURRENT, 
but not for 8.0-RELEASE or 7-ANYTHING. The commit was supposed to fix 
7.3-RELEASE (and probably 7-STABLE) but changed the behavior for 
8.0-RELEASE, too, which probably has not been intended.

I guess, (__FreeBSD_version >= 730000) should be replaced by 
(__FreeBSD_version >= 730000 && __FreeBSD_version < 799999).

The patch attached fixes the build for me on 8.0-RELEASE. (I have 
included the maintainer, gahr@, in Cc).

Cheers,
Jan Henrik
-------------- next part --------------
diff -u x11-toolkits/fltk/files/patch-src_filename_list.cxx.orig x11-toolkits/fltk/files/patch-src_filename_list.cxx
--- x11-toolkits/fltk/files/patch-src_filename_list.cxx.orig	2010-02-25 14:36:59.000000000 +0100
+++ x11-toolkits/fltk/files/patch-src_filename_list.cxx	2010-03-05 16:39:03.000000000 +0100
@@ -14,7 +14,7 @@
  #ifndef HAVE_SCANDIR
    int n = scandir(d, list, 0, sort);
 -#elif defined(__hpux) || defined(__CYGWIN__)
-+#elif defined(__hpux) || defined(__CYGWIN__) || (defined(__FreeBSD__)  && (__FreeBSD_version >= 900006 || (__FreeBSD_version >= 800501 && __FreeBSD_version < 900000) || (__FreeBSD_version >= 730000)))
++#elif defined(__hpux) || defined(__CYGWIN__) || (defined(__FreeBSD__)  && (__FreeBSD_version >= 900006 || (__FreeBSD_version >= 800501 && __FreeBSD_version < 900000) || (__FreeBSD_version >= 730000 && __FreeBSD_version < 799999)))
    // HP-UX, Cygwin define the comparison function like this:
    int n = scandir(d, list, 0, (int(*)(const dirent **, const dirent **))sort);
  #elif defined(__osf__)