gpac-libgpac port not building on amd64

[Josh Carroll]

On Sat, Feb 14, 2009 at 1:42 PM, Troy <troy at twisted.net> wrote:
> I just did a successful portupgrade of multimedia/gpac-libgpac but when
> trying to upgrade the exact same port on amd64, it fails with the
> following error.
>
> Thanks
>
> cc -O3  -O2 -fno-strict-aliasing -pipe  -fPIC -pthread
> -fno-strict-aliasing -Wno-pointer-sign
> -I/usr/ports/multimedia/gpac-libgpac/work/gpac/include  -I../
> -DGPAC_HAVE_CONFIG_H  -fPIC -DPIC -c compositor/events.c -o
> compositor/events.opic
> compositor/events.c: In function 'load_text_node':
> compositor/events.c:239: warning: passing argument 3 of 'gf_utf8_wcstombs'
> from incompatible pointer type
> compositor/events.c:247: warning: passing argument 3 of 'gf_utf8_wcstombs'
> from incompatible pointer type
> cc -O3  -O2 -fno-strict-aliasing -pipe  -fPIC -pthread
> -fno-strict-aliasing -Wno-pointer-sign
> -I/usr/ports/multimedia/gpac-libgpac/work/gpac/include  -I../
> -DGPAC_HAVE_CONFIG_H  -fPIC -DPIC -c compositor/font_engine.c -o
> compositor/font_engine.opic
> cc -O3  -O2 -fno-strict-aliasing -pipe  -fPIC -pthread
> -fno-strict-aliasing -Wno-pointer-sign
> -I/usr/ports/multimedia/gpac-libgpac/work/gpac/include  -I../
> -DGPAC_HAVE_CONFIG_H  -fPIC -DPIC -c compositor/hardcoded_protos.c -o
> compositor/hardcoded_protos.opic
> cc -O3  -O2 -fno-strict-aliasing -pipe  -fPIC -pthread
> -fno-strict-aliasing -Wno-pointer-sign
> -I/usr/ports/multimedia/gpac-libgpac/work/gpac/include  -I../
> -DGPAC_HAVE_CONFIG_H  -fPIC -DPIC -c compositor/mesh.c -o
> compositor/mesh.opic
> In file included from compositor/mesh.c:33:
> compositor/gl_inc.h:45:19: error: GL/gl.h: No such file or directory
> gmake: *** [compositor/mesh.opic] Error 1
> *** Error code 2
>
> Stop in /usr/ports/multimedia/gpac-libgpac.

I ran into this, too. Since I didn't want OpenGL support anyway, I
just added OPTIONS support to this port, and one of those options is
to disable OpenGL support and submitted this as a PR.

The PR hasn't fully posted yet, but here's the URL for when it's in the system:

http://www.freebsd.org/cgi/query-pr.cgi?pr=131681

The patch is here if you're interested:

http://pflog.net/~floyd/gpac-libgpac.patch

cd /usr/ports/multimedia/gpac-libgpac

patch < /path/to/gpac-libgpac.patch

Then just "make config" and unselect the option for OPENGL, and it should build.

The port should have OpenGL as a dependency if OpenGL support is
enabled - as it is now, it's building with GL support if it finds
GL/gl.h and libGL.so, but it should be listed explicitly as a
dependency in the Makefile. I'll work on another patch for that.

As for getting it to build as-is, I think it'd be sufficient to add
-I${LOCALBASE}/include to --extra-cflags and -L${LOCALBASE}/lib to
--extra-ldflags, but I'm not sure this is the "proper" way to do that
(I'd have to check the porter's handbook). It does in fact build
properly by adding those, though so just update those lines in the
Makefile to:

        --extra-cflags="${CFLAGS} ${PTHREAD_CFLAGS} -fPIC
-I${LOCALBASE}/include" \
        --extra-ldflags="${LDFLAGS} ${PTHREAD_LIBS} -L${LOCALBASE}/lib" \

Josh