BSDstats Project v2.0 ...

[Boris Samorodov]

On Mon, 07 Aug 2006 16:56:42 -0500 Paul Schmehl wrote:
> Boris Samorodov wrote:
> > On Mon, 7 Aug 2006 00:42:27 -0300 (ADT) Marc G. Fournier wrote:
> >
> >> I've now committed v2.0 of the 300.statistics periodic script ... this
> >> one adds the device reporting that we'd talked about previously, and
> >> the summary reports now reflect the driver(s) in use for those
> >> deciding to report ...
> >
> > Great, thanks Marc.
> > I just propose a tiny patch (the problem was discussed somewhere
> > today, may be at ports@):
> > -----
> > --- Makefile.orig	Tue Aug  8 01:40:57 2006
> > +++ Makefile	Tue Aug  8 01:41:16 2006
> > @@ -22,6 +22,6 @@
> >  	${MKDIR} ${LOCALBASE}/etc/periodic/monthly
> >  	${CP} ${FILESDIR}/300.statistics ${LOCALBASE}/etc/periodic/monthly
> >  post-install:
> > -	${CAT} pkg-message
> > +	${CAT} ${PKGMESSAGE}
> >  
> Shouldn't that be @${CAT} ${PKGMESSAGE}?

Well, I assume that it's more a style change. An "@" may be prepended
at all those ${XX} commands. But it's up to author. While the change I
propose will work on some non-default settings. And may be the author
wants to show an administrator what is installing to the system.


WBR
-- 
Boris Samorodov (bsam)
Research Engineer, http://www.ipt.ru Telephone & Internet SP
FreeBSD committer, http://www.FreeBSD.org The Power To Serve