vinum revive does not rebuild parity (was vinum rebuildparity, when?)

[Greg 'groggy' Lehey]

On Thursday,  2 September 2004 at 12:17:01 +0200, Stijn Hoop wrote:
> Hi,
>
> back with another episode in this continuing saga:
>
> On Sun, Aug 29, 2004 at 04:26:57PM +0200, Stijn Hoop wrote:
>> Witness this (after yet another fake disk crash):
>>
>>>>>
>>
>> vinum -> ls -v local.p0.s0
>> Subdisk local.p0.s0:
>>                 Size:      31457129472 bytes (29999 MB)
>>                 State: reviving
>>                 Plex local.p0 at offset 0 (0  B)
>>                 Reviver PID:    46863
>>                 Revive pointer:                 22 GB (77%)
>>                 Revive blocksize:               64 kB
>>                 Revive interval:                 0 seconds
>>                 Drive ren (/dev/ad6s1e) at offset 135680 (132 kB)
>>
>> vinum -> vinum[46863]: local.p0.s0 is up
>>
>> vinum -> checkparity local.p0.s0
>> local.p0.s0 is not a plex
>> vinum -> checkparity local.p0
>> Parity incorrect at offset 0x2020
>> vinum -> rebuildparity -V local.p0
>> Parity incorrect at offset 0x2020
>> Rebuilding at 2703 kB (0%)    Parity incorrect at offset 0x2a6664
>> Rebuilding at 139 MB (0%)
>>
>>>>>
>>
>> which indicates that the parity surely is not correctly recalculated during
>> the revive.

If that were the case, the parity would be incorrect at offset 0.
Yes, it is recalculated.

>> Greg, can you tell me if this is correct behaviour?

Sorry for the slow response.  I was at a conference last week.  No,
it's not correct.

> While not having heard back yet, I had to rebuild another subdisk,
> but I decided to do it off-line this time. Turns out the parity was
> rebuilt ok. 

Yes, this is what I recommended.

> Might there be a bug in the online rebuild code?

Looks like it.

The current version of Vinum is on its last legs.  Lukas Ertl is
rewriting it, so don't expect much change in this version.  For the
time being, just accept that you should umount before rebuilding a
plex.

Greg
--
When replying to this message, please copy the original recipients.
If you don't, I may ignore the reply or reply to the original recipients.
For more information, see http://www.lemis.com/questions.html
Note: I discard all HTML mail unseen.
Finger grog at FreeBSD.org for PGP public key.
See complete headers for address and phone numbers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-questions/attachments/20040908/f0368771/attachment.bin