bin/27483: make sysinstall ask for the keymap at installation time

Cyrille Lefevre cyrille.lefevre at laposte.net
Sun Mar 7 02:40:14 PST 2004


The following reply was made to PR bin/27483; it has been noted by GNATS.

From: "Cyrille Lefevre" <cyrille.lefevre at laposte.net>
To: "Peter Pentchev" <roam at ringlet.net>
Cc: <bug-followup at FreeBSD.org>, <freebsd-qa at FreeBSD.org>
Subject: Re: bin/27483: make sysinstall ask for the keymap at installation time
Date: Sat, 6 Mar 2004 02:29:47 +0100

 > On Thu, Mar 04, 2004 at 04:28:09PM +0100, Cyrille Lefevre wrote:
 > > cvs diff against -current (FreeBSD 5.2-CURRENT #1: Sat Jan 31 15:17:05 CET
 2004)
 > > anyone to commit this PR ?
 > > thanks in advance.
 > >
 > [snip]
 > >      /* Begin user dialog at outer menu */
 > >      dialog_clear();
 > > +    if (getpid() == 1)
 > > +        dmenuOpen(&MenuSysconsKeymap, &choice, &scroll, &curr, &max,
 FALSE);
 > >      while (1) {
 >
 > Just a minor comment: shouldn't RunningAsInit be used here instead of
 > a getpid() invocation? :)
 
 maybe, don't know in fact ?
 
 Cyrille Lefevre.
 -- 
 home: mailto:cyrille.lefevre at laposte.net
 


More information about the freebsd-qa mailing list