[patch] fix PYTHON_VERSION in py-setuptoolsXX

Kubilay Kocak koobs.freebsd at gmail.com
Sat Apr 12 03:10:44 UTC 2014


On 12/04/2014 12:38 PM, John Hein wrote:
> The current settings in py-setuptools{27,32,33,34}/Makefile for
> PYTHON_VERSION are wrong (X.Y instead of pythonX.Y), but sort of work
> by chance rather than design.  If it weren't for some unintended luck
> from the way _PYTHON_VERSION is set and the .MAKEFLAGS line in
> bsd.python.mk that forcibly sets
> PYTHON_VERSION=python${_PYTHON_VERSION}, these ports would fail with
> something like:
> 
> Makefile error: bad value for PYTHON_VERSION: 3.3.
> Legal values are:
>   python2.7 (default)
>   python3.1
>   python3.2
>   python3.3
>   python3.4
> 
> 
> Please fix:
> 
> Index: py-setuptools27/Makefile
> ===================================================================
> --- py-setuptools27/Makefile	(revision 350922)
> +++ py-setuptools27/Makefile	(working copy)
> @@ -3,7 +3,7 @@
>  
>  PKGNAMESUFFIX=	${PYTHON_SUFFIX}
>  
> -PYTHON_VERSION=	2.7
> +PYTHON_VERSION=	python2.7
>  
>  MASTERDIR=	${.CURDIR}/../py-setuptools
>  
> Index: py-setuptools32/Makefile
> ===================================================================
> --- py-setuptools32/Makefile	(revision 350922)
> +++ py-setuptools32/Makefile	(working copy)
> @@ -3,7 +3,7 @@
>  
>  PKGNAMESUFFIX=	${PYTHON_SUFFIX}
>  
> -PYTHON_VERSION=	3.2
> +PYTHON_VERSION=	python3.2
>  
>  MASTERDIR=	${.CURDIR}/../py-setuptools
>  
> Index: py-setuptools33/Makefile
> ===================================================================
> --- py-setuptools33/Makefile	(revision 350922)
> +++ py-setuptools33/Makefile	(working copy)
> @@ -3,7 +3,7 @@
>  
>  PKGNAMESUFFIX=	${PYTHON_SUFFIX}
>  
> -PYTHON_VERSION=	3.3
> +PYTHON_VERSION=	python3.3
>  
>  MASTERDIR=	${.CURDIR}/../py-setuptools
>  
> Index: py-setuptools34/Makefile
> ===================================================================
> --- py-setuptools34/Makefile	(revision 350922)
> +++ py-setuptools34/Makefile	(working copy)
> @@ -3,7 +3,7 @@
>  
>  PKGNAMESUFFIX=	${PYTHON_SUFFIX}
>  
> -PYTHON_VERSION=	3.4
> +PYTHON_VERSION=	python3.4
>  
>  MASTERDIR=	${.CURDIR}/../py-setuptools
>  
> 
> _______________________________________________
> freebsd-python at freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-python
> To unsubscribe, send any mail to "freebsd-python-unsubscribe at freebsd.org"
> 

Thanks for the report John (and the one directly to me for bsd.python.mk)

Can you also submit a PR so it can be tracked please. We use these for
our quarterly reports among other things. This will also ensure you are
notified when progress is made.

./koobs


More information about the freebsd-python mailing list