ports/159215: Mk/bsd.python.mk: PYTHON_VERSION is ignored

John Hein jhein at symmetricom.com
Wed Apr 11 19:56:34 UTC 2012


Mel Flynn wrote at 21:47 +0200 on Apr 11, 2012:
 > On 4/11/2012 21:22, John Hein wrote:
 > 
 > > But (#1) neither work because bsd.port.pre.mk defines PYTHON_PORTSDIR
 > > before the new python version can be set by the ARCH == amd64 test.
 > > 
 > > But (#2) you can't put the ARCH .if test before bsd.port.pre.mk since
 > > ARCH is not defined at that point.
 > 
 > Just a thought:
 > You can simplify the hack by including bsd.port.options.mk instead of
 > the first bsd.port.pre.mk. ARCH will be defined while bsd.python.mk
 > isn't included yet.

Indeed.  Although it's a bit counterintuitive to include
bsd.port.options.mk when there are no OPTIONS.  However, it's perhaps
safer than including pre.mk twice and hoping no one changes anything
above the first that leaves USE_PYTHON defined.

Whichever of those hacks is used, there should be a comment about
what's going on and why.


More information about the freebsd-python mailing list