OpenJDK ports and 13-CURRENT

[Dimitry Andric]

On 10 Oct 2020, at 21:49, Shawn Webb <shawn.webb at hardenedbsd.org> wrote:
> 
> On Sat, Oct 10, 2020 at 09:45:58PM +0200, Dimitry Andric wrote:
...
>> The quick way to work around these errors is to set -fcommon in CFLAGS,
>> which will basically fudge around the actual issue. The better way is to
>> get rid of the duplicated symbols. This is usually easy, except that
>> Java ports tend to take ages to build. :) I'll submit a patch when my
>> machine's finished crunching through it.
> 
> Yup. Another victim: print/tex-luatex:
> 
> https://git-01.md.hardenedbsd.org/HardenedBSD/hardenedbsd-ports/commit/229b7663bc82ff7e471dc1e19662f68d4226984a

I looked into this one finally, and it's not really an issue with any
recent clang import, as the PR is from 2018-12-20:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234221

The cause is a mixing of libstdc++ and libc++, which should not be done,
as it will almost always lead to unexpected linking errors.

The following diff fixes that:

Index: Makefile
===================================================================
--- Makefile    (revision 552400)
+++ Makefile    (working copy)
@@ -74,6 +74,8 @@ CONFIGURE_ARGS+=--with-system-$L \
                --with-$L-include=${LOCALBASE}/include \
                --with-$L-libdir=${LOCALBASE}/lib
 .endfor
+CONFIGURE_ARGS+=CC="${CC}" \
+               CXX="${CXX}"
 CPPFLAGS+=     -I${LOCALBASE}/include
 MAKE_JOBS_UNSAFE=      yes
 TEX_FORMATS=   luatex


Note that the port's Makefile already has -fcommon added, to work
around duplicated symbols. Since the copy of texlive is ancient, it is
probably not worth the time to fix the actual issues.

-Dimitry

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 223 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20201017/021c2332/attachment.sig>