textproc/goldendict does not compile on CURRENT

[Matthias Apitz]

Hello,

I was building textproc/goldendict on amd64 CURRENT and it failes to
compile with:

...
--- build/dictionary.o ---
c++ -c -O2 -pipe -fstack-protector-strong -fno-strict-aliasing -rdynamic -frtti -Wall -Wextra -pthread -fPIC -DMAKE_QTMULTIMEDIA_PLAYER -DMAKE_FFMPEG_PLAYER -DHAVE_X11 -DPROGRAM_DATA_DIR=\"/usr/local/share/goldendict/\" -DPROGRAM_VERSION=\"1.5.0-RC2+git\" -DMAKE_ZIM_SUPPORT -DMAKE_EXTRA_TIFF_HANDLER -DNO_EPWING_SUPPORT -DQT_NO_DEBUG -DQT_SVG_LIB -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_HELP_LIB -DQT_WIDGETS_LIB -DQT_WEBKIT_LIB -DQT_MULTIMEDIA_LIB -DQT_X11EXTRAS_LIB -DQT_GUI_LIB -DQT_XML_LIB -DQT_NETWORK_LIB -DQT_SQL_LIB -DQT_CORE_LIB -I. -I. -Iqtsingleapplication/src -I/usr/local/include -I/usr/local/include/hunspell -I/usr/local/include/qt5 -I/usr/local/include/qt5/QtSvg -I/usr/local/include/qt5/QtWebKitWidgets -I/usr/local/include/qt5/QtPrintSupport -I/usr/local/include/qt5/QtHelp -I/usr/local/include/qt5/QtWidgets -I/usr/local/include/qt5/QtWebKit -I/usr/local/include/qt5/QtMultimedia -I/usr/local/include/qt5/QtX11Extras -I/usr/local/include/qt5/QtGui -I/usr/local/include/qt5/QtXml -I/usr/local/include/qt5/QtNetwork -I/usr/local/include/qt5/QtSql -I/usr/local/include/qt5/QtCore -Ibuild -I/usr/local/include/libdrm -Ibuild -I/usr/local/include -I/usr/local/lib/qt5/mkspecs/freebsd-clang -o build/dictionary.o dictionary.cc
...
In file included from dictionary.cc:7:
In file included from ./dictionary.hh:10:
In file included from /usr/local/include/qt5/QtCore/QObject:1:
In file included from /usr/local/include/qt5/QtCore/qobject.h:47:
/usr/local/include/qt5/QtCore/qstring.h:1229:22: warning: definition of implicit copy constructor for 'QCharRef' is deprecated because it has a user-declared copy assignment operator [-Wdeprecated-copy]
    inline QCharRef &operator=(const QCharRef &c) { return operator=(QChar(c)); }
                     ^
/usr/local/include/qt5/QtCore/qstring.h:1329:38: note: in implicit copy constructor for 'QCharRef' first required here
{ Q_ASSERT(i >= 0); detach(); return QCharRef(*this, i); }
                                     ^
In file included from dictionary.cc:7:
In file included from ./dictionary.hh:13:
./sptr.hh:71:12: error: cannot initialize return object of type 'unsigned int' with an lvalue of type 'unsigned int *const'
  { return count; }
           ^~~~~

I helped me mofifying the source to 

  { return * count; }

and wanted to file an issue upstream.

But it seems that the bug is already with:

https://github.com/goldendict/goldendict/issues/1267

So, our port needs an update or a patch file to fix this.

	matthias

-- 
Matthias Apitz, ✉ guru at unixarea.de, http://www.unixarea.de/ +49-176-38902045
Public GnuPG key: http://www.unixarea.de/key.pub
Без книги нет знания, без знания нет коммунизма (Влaдимир Ильич Ленин)
Without books no knowledge - without knowledge no communism (Vladimir Ilyich Lenin) 
Sin libros no hay saber - sin saber no hay comunismo. (Vladimir Ilich Lenin)