FYI: x11/xscreensaver appears to have a build-race

[Niclas Zeising]

On 2019-08-18 09:48, Mark Millard wrote:
> 
> 
> On 2019-Aug-18, at 00:34, Niclas Zeising <zeising at freebsd.org> wrote:
> 
>> On 2019-08-18 09:07, Mark Millard via freebsd-ports wrote:
>>> I ran two separate devel/poudriere-devel amd64->aarch64
>>> cross builds on the same system (head -r 351178 based)
>>> with the same /usr/ports/ tree (ports head -r509171),
>>> building the same 97 ports each, mostly overlapping
>>> in time, and one got:
>>> gmake[2]: *** [Makefile:37: gen/apple_png.h] Error 2
>>> while building x11/xscreensaver but the other
>>> completed building x11/xscreensaver just fine.
>>> There was also a armv7-targeting poudriere-devel ports
>>> update running, also mostly overlapping in time. With
>>> 28 FreeBSD CPUs (under Hyper-V), the load average was
>>> frequently over 90. (The armv7 x11/xscreensaver build
>>> also completed fine.)
>>> All 3 poudriere's had ALLOW_MAKE_JOBS=yes and all 3 set
>>> up to have "Building 97 packages using 28 builders".
>>> devel/llvm90 was one of the ports being built. All 3
>>> poudriere's had native-xtools in use. The context has
>>> ECC DRAM, 96 GiBytes worth.
>>
>> I'm just about to update x11/xscreensaver, but through multiple poudriere runs I haven't noticed any issues.  I have a much smaller machine to do builds on though.
>> It would be interesting to see more context of the error as well.
> 
> Here you go:
> 

Thank you

> 
> 
> The overall build is still in progress. So I've not had
> a chance to run poudriere again to have it retry just
> the 3 ports (1 failed and 2 skipped). (Presumes the rest
> build okay.)
> 
> 
> A race suggests that MAKE_JOBS_UNSAFE=yes may well be appropriate.

I'll look into it.  However, this is the only report I have of this 
issue, so it's not very common, and setting MAKE_JOBS_UNSAFE would slow 
down the build quite a lot.

The error is a little strange, since it looks like it is when generating 
apple_png.h.  I wonder which file it is that it complains about not 
being there...
Regards
-- 
Niclas Zeising