ports/arj build failing on -current

[Renato Botelho]

On 08/08/19 11:02, Walter Schwarzenfeld wrote:
> msgbind.c:452:50: warning: if statement has empty body [-Wempty-body]
>   if(argv[6][strlen(argv[6])-1]!=PATHSEP_DEFAULT);
>                                                  ^
> msgbind.c:452:50: note: put the semicolon on a separate line to silence
> this warning
> 1 warning generated.
> 
> Do what it want. Try to =>  put the semicolon on a separate line.
> 
> (althrough it is a warning, I remember a case, this simple thing "was it").

[resending to the list with proper From]

It looks like that semicolon shouldn't be there.

Michael, can you try attached patch and let me know if it fixes the
problem?  I can't reproduce so it's hard to say.

-- 
Renato Botelho
-------------- next part --------------
Index: Makefile
===================================================================
--- Makefile	(revision 508386)
+++ Makefile	(working copy)
@@ -3,7 +3,7 @@
 
 PORTNAME=	arj
 PORTVERSION=	3.10.22
-PORTREVISION=	8
+PORTREVISION=	9
 CATEGORIES=	archivers
 MASTER_SITES=	SF/${PORTNAME}/${PORTNAME}/2.78_3.10%20build%2022:source \
 		DEBIAN_POOL:patch
Index: files/patch-msgbind.c
===================================================================
--- files/patch-msgbind.c	(nonexistent)
+++ files/patch-msgbind.c	(working copy)
@@ -0,0 +1,11 @@
+--- msgbind.c.orig	2019-08-08 14:39:25 UTC
++++ msgbind.c
+@@ -449,7 +449,7 @@ int main(int argc, char **argv)
+   strcpyn(target_n, argv[6], sizeof(target_n)-8);
+   strcpyn(target_f, argv[6], sizeof(target_f)-8);
+   strcpyn(target_h, argv[6], sizeof(target_f)-8); /* v 1.41+ */
+-  if(argv[6][strlen(argv[6])-1]!=PATHSEP_DEFAULT);
++  if(argv[6][strlen(argv[6])-1]!=PATHSEP_DEFAULT)
+   {
+    strcat(target_i, pathsep);
+    strcat(target_n, pathsep);

Property changes on: files/patch-msgbind.c
___________________________________________________________________
Added: fbsd:nokeywords
## -0,0 +1 ##
+yes
\ No newline at end of property
Added: svn:eol-style
## -0,0 +1 ##
+native
\ No newline at end of property
Added: svn:mime-type
## -0,0 +1 ##
+text/plain
\ No newline at end of property