r479405 ("PLIST_SUB must be appended to") missing lang/gcc8 ?

[Mathieu Arnold]

Hi,

On Sun, Nov 18, 2018 at 07:21:08AM -0700, Gerald Pfeifer wrote:
> Hi Mat,
> 
> I noticed that 
> 
>   r479405 | mat | 2018-09-10 13:11:23 +0000 (Mo., 10 Sep. 2018) | 9 lines
> 
>   After an include, PLIST_SUB must be appended to, not overwritten.
> 
>   If it is overwritten, many values will be clobbered, and
>   pain will ensue.
> 
>   PR:             230864
>   Submitted by:   mat
>   exp-runs by:    antoine
> 
> did not cover lang/gcc8 (nor lang/gcc9-devel).
> 
> 
> OTOH `diff lang/gcc7/Makefile lang/gcc8` shows this as nearly the only
> difference between the two versions, short of version-specific lines.
> 
> 
> Does this look like an small omission I should address?  I have this 
> locally and tested, but figured I'd double check before committing.

Yes, it should be fixed, thanks for finding It.  I'm not sure why I did
not picked those two ports at the time, maybe I was working on the patch
for too long and missed the ports being added.


> Gerald
> 
> 
> Index: lang/gcc8/Makefile
> ===================================================================
> --- lang/gcc8/Makefile	(revision 485224)
> +++ lang/gcc8/Makefile	(working copy)
> @@ -95,7 +95,7 @@
>  		--with-system-zlib
>  MAKE_ARGS+=	MAKEINFOFLAGS="--no-split"
>  USE_LDCONFIG=	${TARGLIB}
> -PLIST_SUB=	GCC_VERSION=${GCC_VERSION} \
> +PLIST_SUB+=	GCC_VERSION=${GCC_VERSION} \
>  		GNU_HOST=${CONFIGURE_TARGET} \
>  		SUFFIX=${SUFFIX}
>  INFO=		gcc${SUFFIX}/cpp \
> Index: lang/gcc9-devel/Makefile
> ===================================================================
> --- lang/gcc9-devel/Makefile	(revision 485224)
> +++ lang/gcc9-devel/Makefile	(working copy)
> @@ -97,7 +97,7 @@
>  		--with-system-zlib
>  MAKE_ARGS+=	MAKEINFOFLAGS="--no-split"
>  USE_LDCONFIG=	${TARGLIB}
> -PLIST_SUB=	GCC_VERSION=${GCC_VERSION} \
> +PLIST_SUB+=	GCC_VERSION=${GCC_VERSION} \
>  		GNU_HOST=${CONFIGURE_TARGET} \
>  		SUFFIX=${SUFFIX}
>  INFO=		gcc${SUFFIX}/cpp \
> 

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20181120/34f70d0d/attachment.sig>