certbot lost certificates , and registration data

[Kubilay Kocak]

On 11/12/2018 1:43 am, Matthew Seaman wrote:
> On 10/12/2018 14:10, Paul Macdonald via freebsd-ports wrote:
>>
>> On 10/12/2018 13:15, Paul Macdonald via freebsd-questions wrote:
>>>
>>> Is anyone else seeing py-certbot having lost all installed certs, and 
>>> the initial registation data?
>>>
>>> There was an update on the 7th
>>>
>>> Upgrade of py27-certbot-0.28.0_1,1 to py27-certbot-0.29.1_1,1
>>>
>>> and on 3 boxes tested so far, which all had certs, i now see no certs 
>>> listed and a request to redo the initial registation on attempts to 
>>> install a new cert.
>>>
>>> i don't see any issues upstream here: 
>>> https://github.com/letsencrypt/boulder/issues/ so not sure if this is 
>>> FBSD thing or not.
>>>
>>> Paul.
>>
>>
>> passing --config-dir /usr/local/etc/letsencrypt shows expected output, 
>> i suspect something has happend with that flag on the upgrade ( i see 
>> /etc/letsencrypt directories on affected servers)
>>
>>
>>>
>>>
> 
> This upstream commit:
> 
> https://github.com/certbot/certbot/commit/a23d76beb0e2c9539670766045314a5d50f582a2#diff-64ccdc74e8a07f9b039a6254093f1d0d 
> 
> 
> breaks the post-patch target in the security/certbot port Makefile:
> 
> post-patch:
>          @${REINPLACE_CMD} \
>                  -e 's|/etc/|${LOCALBASE}/etc/|' \
>                  -e 's|/var/lib|/var/db|' \
>                  ${WRKSRC}/${PORTNAME}/constants.py
> 
> Looks like the REINPLACE_CMD should be applied to 
> ${WRKSRC}/${PORTNAME}/compat.py now.
> 
> Or compat.py should be patched to grok FREEBSD_DEFAULT_FOLDERS
> 
>      Cheers,
> 
>      Matthew
> 

Nice find Matthew.

Prefer the latter (and sent upstream). Can one of you create a bugzilla 
issue for this and cc me please.

If you'd like to give a representative/attempted patch a go, please do.

./koobs