Blackbox does not compile, diff in here
Kubilay Kocak
koobs at FreeBSD.org
Thu Aug 9 04:34:25 UTC 2018
On 9/08/2018 12:29 pm, Erich Dollansky wrote:
> Hi,
>
> I do not know if somebody spotted this already. Some casting was done
> to the wrong types.
Hi Erich,
This looks like https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226708
The first and third chunks below appear to be noise/spurious/unnecessary
though.
> Erich
>
> PS I am not experienced in creating diffs for ports. This one was done
> in the working directory's lib entry:
>
>
> --- EWMH.cc.180809 2005-01-24
> 15:50:56.000000000 +0800 +++ EWMH.cc 2018-08-09 10:10:05.630203000
> +0800 @@ -204,7 +204,7 @@
> bool bt::EWMH::readNumberOfDesktops(Window target,
> unsigned int* number) const {
> unsigned char* data = 0;
> - if (getProperty(target, XA_CARDINAL, net_number_of_desktops, &data))
> {
> + if (getProperty (target, XA_CARDINAL, net_number_of_desktops,
> &data)) { *number =
> static_cast<unsigned int>(*(reinterpret_cast<unsigned long
> *>(data)));
> @@ -246,8 +246,11 @@
>
>
> void bt::EWMH::setDesktopViewport(Window target, int x, int y) const {
> + //
> + // 09.08.18 ed: the following statement was modified.
> + //
> const unsigned long viewport[] =
> - { static_cast<long>(x), static_cast<long>(y) };
> + { static_cast<unsigned long>(x), static_cast<unsigned long>(y) };
> setProperty(target, XA_CARDINAL, net_desktop_viewport,
> reinterpret_cast<const unsigned char *>(viewport), 2);
> }
> @@ -644,8 +647,10 @@
> }
>
>
> -bool bt::EWMH::getProperty(Window target, Atom type, Atom property,
> - unsigned char** data) const {
> +bool bt::EWMH::getProperty (Window target, Atom type, Atom property,
> + unsigned char ** data) const {
> Atom atom_return;
> int size;
> unsigned long nitems, bytes_left;
> _______________________________________________
> freebsd-ports at freebsd.org mailing list
> https://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe at freebsd.org"
>
More information about the freebsd-ports
mailing list