Stage-qa doesn't complain about unstripped elfs in many cases

[Mathieu Arnold]

On Tue, Aug 07, 2018 at 11:29:39PM -0700, Yuri wrote:
> For example, on the misc/orange3 port:
> 
> > $ make stage-qa
> > ====> Running Q/A tests (stage-qa)
> > [yuri at yv /usr/ports/misc/orange3]$ file ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so
> > ./work-py36/stage/usr/local/lib/python3.6/site-packages/Orange/widgets/utils/_grid_density.so:
> ELF 64-bit LSB shared object, x86-64, version 1 (FreeBSD), dynamically
> linked, not stripped
> 
> 
> This is because the stage-qa check only looks at .debug sections, and
> file(1) looks at more sections.
> 
> My proposed partial fix was rejected:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230371 on the grounds that
> it goes against some other commit. So stage-qa doesn't check what it is
> supposed to check, and this is somehow ok.
> 
> 
> Should this stage-qa check be changed to just run file(1) and check if the
> output contains "not stripped" in it? What would be the downside of this? I
> also don't understand what is the downside of the rejected patch in
> bug#230371 that expands the list of sections.

I do not understand the point of this email.

I already told you that this was going against our policy.

The QA check does exactly what it needs to do.

-- 
Mathieu Arnold
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20180808/082faa05/attachment.sig>