Bogofilter contrib scripts treated as docs

[RW]

On Thu, 9 Nov 2017 23:12:48 +0100
Matthias Andree wrote:

> Am 06.11.2017 um 20:19 schrieb RW:
> > 
> > I just noticed that the bogofilter perl and shell scripts from the
> > contrib directory (see below) only get installed if bogofilter is
> > built with the DOCS option.
> > 
> > 
> > .for i in bfproxy.pl bogofilter-milter.pl bogo.R bogofilter-qfe.sh \
> >        mime.get.rfc822.pl parmtest.sh printmaildir.pl \
> >        bogominitrain.pl \
> >        randomtrain.sh scramble.sh spamitarium.pl stripsearch.pl
> > trainbogo.sh ${INSTALL_SCRIPT} ${WRKSRC}/contrib/${i}
> > ${STAGEDIR}${DOCSDIR}/contrib/${i} .endfor
> >   
> 
> Yes, that is true, and these are contrib/uted, so are not necessary
> for normal operation.  

Neither are bogolexer, bogotune or bogoutil. Some of these scripts are
arguably more useful and can be essential for normal operation if a
system has been set-up to rely on them. The loss of spamitarium or
bogofilter-milter can stop bogofilter from being run.

> So what are you suggesting?

They aren't documentation, they're functional. Losing functionality
when deselecting DOCS is a serious POLA violation.

If they need to be optional it should be a separate option, but they
are only 216kB in total.