diff and submissions

Baptiste Daroussin bapt at FreeBSD.org
Fri May 5 10:37:47 UTC 2017


On Fri, May 05, 2017 at 12:27:13PM +0200, Mathieu Arnold wrote:
> Le 05/05/2017 à 12:20, Baptiste Daroussin a écrit :
> > On Fri, May 05, 2017 at 12:17:06PM +0200, Mathieu Arnold wrote:
> >> Le 05/05/2017 à 08:16, Franco Fichtner a écrit :
> >>>> On 4. May 2017, at 10:20 AM, Mathieu Arnold <mat at FreeBSD.org> wrote:
> >>>>
> >>>> If you went as far as being able to create a pull request, you can do a
> >>>> git show HEAD or git diff origin/trunk...HEAD and submit that in the
> >>>> FreeBSD PR as well.
> >>> It's pretty easy to extract the diff from a PR on GitHub, just append
> >>> ".diff", and ".patch" works too, but gives the full git commit history:
> >>>
> >>> https://github.com/freebsd/freebsd-ports/pull/62.diff
> >> Yes, I am aware of that, the problem with github pull requests is that
> >> they are outside of the FreeBSD bug report process, they do not get
> >> assigned to maintainers, nobody notices them, they just stay there, and
> >> get obsolete.
> >> There have been 61 before, yes, I closed a lot because they were
> >> obsolete because it is outside of our process and nobody noticed them,
> >> and for the rest either asked the submitter to open a PR on our
> >> bugzilla, or opened one myself.
> >>
> > I made a script which is a few lines of shell that converts pull requests to
> > phabricator reviews automatically.
> >
> > I have handed it to some of the phabricator admins, I hope it will be progress
> > soon.
> 
> 
> Please, do not do that.
> 
> Phabricator is for code review, not bug reports.  It all ends up in our
> repository, but Phabricator does not have any maintainer notification
> like Bugzilla has.
> robak@ has a script that does pull-request -> bugzilla, and it has been
> waiting for months for someone with access to do something about it.
> 

Pull request are for code submissions and phabricator is the equivalent for that

Bapt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-ports/attachments/20170505/4c965a46/attachment.sig>


More information about the freebsd-ports mailing list