foswiki fails to install

[Chris H]

On Fri, 17 Mar 2017 16:08:47 -0600 Adam Weinberger <adamw at adamw.org> wrote

> > On 17 Mar, 2017, at 15:33, Chris H <bsd-lists at bsdforge.com> wrote:
> > 
> > On Fri, 17 Mar 2017 19:15:19 +0000 Doug Sampson <dougs at dawnsign.com> wrote
> > 
> >> I'm trying to install a fresh instance of www/foswiki version 2.1.3 and
> >> it's failing as follows: 
> >> 
> >> root at draco:/usr/ports/www/foswiki # make install clean
> >> ===>  Patching for foswiki-2.1.3
> >> ===>  Applying FreeBSD patches for foswiki-2.1.3
> >> File to patch:
> >> No file found--skip this patch? [n] y
> >> 1 out of 1 hunks ignored--saving rejects to Oops.rej
> >> => FreeBSD patch patch-minifycss failed to apply cleanly.
> >> *** Error code 1
> >> 
> >> Stop.
> >> make[1]: stopped in /usr/ports/www/foswiki
> >> *** Error code 1
> >> 
> >> Stop.
> >> make: stopped in /usr/ports/www/foswiki
> >> root at draco:/usr/ports/www/foswiki #
> >> 
> >> What's up? Why would I need to apply patch(es) when installing for the
> >> first time? 
> > There are frequently patches required to install
> > software from the ports tree. Whether a first-time install,
> > or an upgrade.
> > In *this* case, however; I submitted pr(1) 217342, that
> > upgraded www/foswiki from 1.1.9 -> 2.1.3. The svn diff I
> > provided, *deleted* 2 files (patches) that were needed in
> > version 1.1.9, but not in version 2.1.3. However, the
> > deleted patches weren't reflected in the merge (commit)
> > 435357. I became aware of this shortly after the commit,
> > and opened a new pr(1) -- 217759, to address the issue.
> > But no one has responded.
> > In the short-term, you can simply delete the following
> > two files within the www/foswiki port:
> > files/patch-minifycss
> > files/patch-minifyjs
> > 
> > and the port will install as intended. I can't
> > explain why the files still show up, after the commit.
> > They should have been deleted.
> > 
> > HTH
> > 
> > --Chris
> 
> Fixed in r436351. FWIW, when a PR contains a patch that deletes a file, it's
> best if you add a reminder in the description. It's so easy to hit 'rm'
> instead of 'svn rm'. 
>
> # Adam
I use svn delete. But no matter. In the future, I'll *always*
indicate any deletions.

Thanks for such a fast response, Adam! Greatly appreciated! :-)

--Chris
> 
> 
> -- 
> Adam Weinberger
> adamw at adamw.org
> https://www.adamw.org